drbd: Remove redundant and wrong test for NULL simplification in conn_connect()
Since the drbd_socket_okay() function itself tests if the the socket is NULL, the explicit test "if (sock.socket && &msock.socket)" was redundent. Apart from that the address opperator ('&') before msock.socket rendered the test pointless. Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
This commit is contained in:
parent
3174f8c504
commit
b666dbf819
drivers/block/drbd
|
@ -985,13 +985,9 @@ static int conn_connect(struct drbd_tconn *tconn)
|
|||
goto out_release_sockets;
|
||||
}
|
||||
|
||||
if (sock.socket && &msock.socket) {
|
||||
ok = drbd_socket_okay(&sock.socket);
|
||||
ok = drbd_socket_okay(&msock.socket) && ok;
|
||||
if (ok)
|
||||
break;
|
||||
}
|
||||
} while (1);
|
||||
ok = drbd_socket_okay(&sock.socket);
|
||||
ok = drbd_socket_okay(&msock.socket) && ok;
|
||||
} while (!ok);
|
||||
|
||||
if (ad.s_listen)
|
||||
sock_release(ad.s_listen);
|
||||
|
|
Loading…
Reference in New Issue