p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

kconfig: use snprintf for formatting pathnames 

Valid pathnames will never exceed PATH_MAX, but these file names
are unsanitized and can cause buffer overflow if set incorrectly.
Use snprintf to avoid this. This was flagged during a Coverity scan
of the coreboot project, which also uses kconfig for its build system.

Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
This commit is contained in:
Jacob Garber 2019-05-10 13:28:52 -06:00 committed by Masahiro Yamada
parent 4cb726121e
commit b9d1a8e930
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/kconfig/confdata.c
View File

@ -241,7 +241,7 @@ char *conf_get_default_confname(void)
name = expand_string(conf_defname); name = expand_string(conf_defname);
env = getenv(SRCTREE); env = getenv(SRCTREE);
if (env) { if (env) {
sprintf(fullname, "%s/%s", env, name); snprintf(fullname, sizeof(fullname), "%s/%s", env, name);
if (is_present(fullname)) if (is_present(fullname))
return fullname; return fullname;
} }

3
scripts/kconfig/lexer.l
View File

@ -378,7 +378,8 @@ FILE *zconf_fopen(const char *name)
if (!f && name != NULL && name[0] != '/') { if (!f && name != NULL && name[0] != '/') {
env = getenv(SRCTREE); env = getenv(SRCTREE);
if (env) { if (env) {
sprintf(fullname, "%s/%s", env, name); snprintf(fullname, sizeof(fullname),
"%s/%s", env, name);
f = fopen(fullname, "r"); f = fopen(fullname, "r");
} }
} }