p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf evlist: Remove unused perf_evlist__fprintf() method 

Ditch it, noone is using it, one more stdio.h include in a hot header.

Fix the fallout in parse-events.y, where we end up using a FILE pointer,
I think due to YYDEBUG being set and in some places, like Amazon Linux 1
we don't get stdio.h included by luck, like in most other places, add a
explicit stdio.h include directive.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-37k5q0lhdbo2hvvfbnnzn7og@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo 2019-09-24 15:45:21 -03:00
parent ca1252779f
commit bd70462062
3 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/perf/util/evlist.c
View File

@ -1421,19 +1421,6 @@ int perf_evlist__parse_sample_timestamp(struct evlist *evlist,
return perf_evsel__parse_sample_timestamp(evsel, event, timestamp); return perf_evsel__parse_sample_timestamp(evsel, event, timestamp);
} }
size_t perf_evlist__fprintf(struct evlist *evlist, FILE *fp)
{
struct evsel *evsel;
size_t printed = 0;
evlist__for_each_entry(evlist, evsel) {
printed += fprintf(fp, "%s%s", evsel->idx ? ", " : "",
perf_evsel__name(evsel));
}
return printed + fprintf(fp, "\n");
}
int perf_evlist__strerror_open(struct evlist *evlist, int perf_evlist__strerror_open(struct evlist *evlist,
int err, char *buf, size_t size) int err, char *buf, size_t size)
{ {

3
tools/perf/util/evlist.h
View File

@ -7,7 +7,6 @@
#include <linux/refcount.h> #include <linux/refcount.h>
#include <linux/list.h> #include <linux/list.h>
#include <api/fd/array.h> #include <api/fd/array.h>
#include <stdio.h>
#include <internal/evlist.h> #include <internal/evlist.h>
#include <internal/evsel.h> #include <internal/evsel.h>
#include "events_stats.h" #include "events_stats.h"
@ -249,8 +248,6 @@ static inline struct evsel *evlist__last(struct evlist *evlist)
return container_of(evsel, struct evsel, core); return container_of(evsel, struct evsel, core);
} }
size_t perf_evlist__fprintf(struct evlist *evlist, FILE *fp);
int perf_evlist__strerror_open(struct evlist *evlist, int err, char *buf, size_t size); int perf_evlist__strerror_open(struct evlist *evlist, int err, char *buf, size_t size);
int perf_evlist__strerror_mmap(struct evlist *evlist, int err, char *buf, size_t size); int perf_evlist__strerror_mmap(struct evlist *evlist, int err, char *buf, size_t size);

1
tools/perf/util/parse-events.y
View File

@ -9,6 +9,7 @@
#define YYDEBUG 1 #define YYDEBUG 1
#include <fnmatch.h> #include <fnmatch.h>
#include <stdio.h>
#include <linux/compiler.h> #include <linux/compiler.h>
#include <linux/list.h> #include <linux/list.h>
#include <linux/types.h> #include <linux/types.h>