drivers: remoteproc: constify rproc_ops structures
Declare rproc_ops structures as const as they are only passed as an argument to the function rproc_alloc. This argument is of type const, so rproc_ops structures having this property can be declared const too. Done using Coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct rproc_ops i@p = {...}; @ok1@ identifier r1.i; position p; @@ rproc_alloc(...,&i@p,...) @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct rproc_ops i; File size details: Size of the file remoteproc/da8xx_remoteproc.o remains the same before and after applying the changes. text data bss dec hex filename 1312 100 4 1416 588 remoteproc/da8xx_remoteproc.o 1312 100 4 1416 588 remoteproc/da8xx_remoteproc.o 970 240 0 1210 4ba remoteproc/omap_remoteproc.o 1002 192 0 1194 4aa remoteproc/omap_remoteproc.o 1901 240 0 2141 85d remoteproc/st_remoteproc.o 1933 192 0 2125 84d remoteproc/st_remoteproc.o 1288 96 0 1384 568 remoteproc/st_slim_rproc.o 1320 64 0 1384 568 remoteproc/st_slim_rproc.o 2121 240 0 2361 939 remoteproc/wkup_m3_rproc.o 2161 192 0 2353 931 remoteproc/wkup_m3_rproc.o Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This commit is contained in:
parent
19f902b53b
commit
c008fad264
|
@ -151,7 +151,7 @@ static void da8xx_rproc_kick(struct rproc *rproc, int vqid)
|
|||
writel(SYSCFG_CHIPSIG2, drproc->chipsig);
|
||||
}
|
||||
|
||||
static struct rproc_ops da8xx_rproc_ops = {
|
||||
static const struct rproc_ops da8xx_rproc_ops = {
|
||||
.start = da8xx_rproc_start,
|
||||
.stop = da8xx_rproc_stop,
|
||||
.kick = da8xx_rproc_kick,
|
||||
|
|
|
@ -177,7 +177,7 @@ static int omap_rproc_stop(struct rproc *rproc)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static struct rproc_ops omap_rproc_ops = {
|
||||
static const struct rproc_ops omap_rproc_ops = {
|
||||
.start = omap_rproc_start,
|
||||
.stop = omap_rproc_stop,
|
||||
.kick = omap_rproc_kick,
|
||||
|
|
|
@ -107,7 +107,7 @@ static int st_rproc_stop(struct rproc *rproc)
|
|||
return sw_err ?: pwr_err;
|
||||
}
|
||||
|
||||
static struct rproc_ops st_rproc_ops = {
|
||||
static const struct rproc_ops st_rproc_ops = {
|
||||
.start = st_rproc_start,
|
||||
.stop = st_rproc_stop,
|
||||
};
|
||||
|
|
|
@ -200,7 +200,7 @@ static void *slim_rproc_da_to_va(struct rproc *rproc, u64 da, int len)
|
|||
return va;
|
||||
}
|
||||
|
||||
static struct rproc_ops slim_rproc_ops = {
|
||||
static const struct rproc_ops slim_rproc_ops = {
|
||||
.start = slim_rproc_start,
|
||||
.stop = slim_rproc_stop,
|
||||
.da_to_va = slim_rproc_da_to_va,
|
||||
|
|
|
@ -111,7 +111,7 @@ static void *wkup_m3_rproc_da_to_va(struct rproc *rproc, u64 da, int len)
|
|||
return va;
|
||||
}
|
||||
|
||||
static struct rproc_ops wkup_m3_rproc_ops = {
|
||||
static const struct rproc_ops wkup_m3_rproc_ops = {
|
||||
.start = wkup_m3_rproc_start,
|
||||
.stop = wkup_m3_rproc_stop,
|
||||
.da_to_va = wkup_m3_rproc_da_to_va,
|
||||
|
|
Loading…
Reference in New Issue