p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mfd: syscon: Make syscon_regmap_config const 

syscon_regmap_config can be made const if syscon_probe() creates a local
copy on the stack, just like syscon_register() does.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Philipp Zabel 2016-01-29 10:30:16 +01:00 committed by Lee Jones
parent ca668f0edf
commit c131045d5b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/mfd/syscon.c
View File

@ -36,7 +36,7 @@ struct syscon {
struct list_head list; struct list_head list;
}; };
static struct regmap_config syscon_regmap_config = { static const struct regmap_config syscon_regmap_config = {
.reg_bits = 32, .reg_bits = 32,
.val_bits = 32, .val_bits = 32,
.reg_stride = 4, .reg_stride = 4,
@ -199,6 +199,7 @@ static int syscon_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct syscon_platform_data *pdata = dev_get_platdata(dev); struct syscon_platform_data *pdata = dev_get_platdata(dev);
struct syscon *syscon; struct syscon *syscon;
struct regmap_config syscon_config = syscon_regmap_config;
struct resource *res; struct resource *res;
void __iomem *base; void __iomem *base;
@ -214,11 +215,10 @@ static int syscon_probe(struct platform_device *pdev)
if (!base) if (!base)
return -ENOMEM; return -ENOMEM;
syscon_regmap_config.max_register = res->end - res->start - 3; syscon_config.max_register = res->end - res->start - 3;
if (pdata) if (pdata)
syscon_regmap_config.name = pdata->label; syscon_config.name = pdata->label;
syscon->regmap = devm_regmap_init_mmio(dev, base, syscon->regmap = devm_regmap_init_mmio(dev, base, &syscon_config);
&syscon_regmap_config);
if (IS_ERR(syscon->regmap)) { if (IS_ERR(syscon->regmap)) {
dev_err(dev, "regmap init failed\n"); dev_err(dev, "regmap init failed\n");
return PTR_ERR(syscon->regmap); return PTR_ERR(syscon->regmap);