p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Target/iser: Get isert_conn reference once got to connected_handler 

In case the connection didn't reach connected state, disconnected
handler will never be invoked thus the second kref_put on
isert_conn will be missing.

Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Cc: <stable@vger.kernel.org> # v3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Sagi Grimberg 2014-07-02 16:19:24 +03:00 committed by Nicholas Bellinger
parent 9e82bf0141
commit c2f88b17a1
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/infiniband/ulp/isert/ib_isert.c
View File

@ -586,7 +586,6 @@ isert_connect_request(struct rdma_cm_id *cma_id, struct rdma_cm_event *event)
init_completion(&isert_conn->conn_wait); init_completion(&isert_conn->conn_wait);
init_completion(&isert_conn->conn_wait_comp_err); init_completion(&isert_conn->conn_wait_comp_err);
kref_init(&isert_conn->conn_kref); kref_init(&isert_conn->conn_kref);
kref_get(&isert_conn->conn_kref);
mutex_init(&isert_conn->conn_mutex); mutex_init(&isert_conn->conn_mutex);
spin_lock_init(&isert_conn->conn_lock); spin_lock_init(&isert_conn->conn_lock);
INIT_LIST_HEAD(&isert_conn->conn_fr_pool); INIT_LIST_HEAD(&isert_conn->conn_fr_pool);
@ -746,7 +745,9 @@ isert_connect_release(struct isert_conn *isert_conn)
static void static void
isert_connected_handler(struct rdma_cm_id *cma_id) isert_connected_handler(struct rdma_cm_id *cma_id)
{ {
return; struct isert_conn *isert_conn = cma_id->context;
kref_get(&isert_conn->conn_kref);
} }
static void static void