From c4fc5d6d0b3750a17e3ee032f2c47620bed4e25a Mon Sep 17 00:00:00 2001 From: "weiyongjun \\(A\\)" Date: Wed, 17 Jan 2018 11:40:34 +0000 Subject: [PATCH] hwrng: bcm2835 - Remove redundant dev_err call in bcm2835_rng_probe() There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Reviewed-by: Eric Anholt Acked-by: Florian Fainelli Signed-off-by: Herbert Xu --- drivers/char/hw_random/bcm2835-rng.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c index 25e56311a197..7a84cec30c3a 100644 --- a/drivers/char/hw_random/bcm2835-rng.c +++ b/drivers/char/hw_random/bcm2835-rng.c @@ -158,10 +158,8 @@ static int bcm2835_rng_probe(struct platform_device *pdev) /* map peripheral */ priv->base = devm_ioremap_resource(dev, r); - if (IS_ERR(priv->base)) { - dev_err(dev, "failed to remap rng regs"); + if (IS_ERR(priv->base)) return PTR_ERR(priv->base); - } /* Clock is optional on most platforms */ priv->clk = devm_clk_get(dev, NULL);