p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

video/omap: remove invalid check 

regno is unsigned so it cannot be negative.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Andrzej Hajda 2015-09-21 15:34:00 +02:00 committed by Tomi Valkeinen
parent 8a9d4626db
commit c50d5cd235
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/video/fbdev/omap/omapfb_main.c
View File

@ -276,11 +276,6 @@ static int _setcolreg(struct fb_info *info, u_int regno, u_int red, u_int green,
if (r != 0) if (r != 0)
break; break;
if (regno < 0) {
r = -EINVAL;
break;
}
if (regno < 16) { if (regno < 16) {
u16 pal; u16 pal;
pal = ((red >> (16 - var->red.length)) << pal = ((red >> (16 - var->red.length)) <<