From c886fa3cf6ffbe13006053ceb27c93d41928de30 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Tue, 22 Jun 2021 09:43:56 +0200 Subject: [PATCH] configfs: simplify configfs_release_bin_file Remove the clearing of various fields just before freeing the buffer structure. Signed-off-by: Christoph Hellwig --- fs/configfs/file.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fs/configfs/file.c b/fs/configfs/file.c index 396418333513..2f63bf3a7325 100644 --- a/fs/configfs/file.c +++ b/fs/configfs/file.c @@ -393,11 +393,8 @@ static int configfs_release_bin_file(struct inode *inode, struct file *file) { struct configfs_buffer *buffer = file->private_data; - buffer->read_in_progress = false; - if (buffer->write_in_progress) { struct configfs_fragment *frag = to_frag(file); - buffer->write_in_progress = false; down_read(&frag->frag_sem); if (!frag->frag_dead) { @@ -410,9 +407,6 @@ static int configfs_release_bin_file(struct inode *inode, struct file *file) } vfree(buffer->bin_buffer); - buffer->bin_buffer = NULL; - buffer->bin_buffer_size = 0; - buffer->needs_read_fill = 1; configfs_release(inode, file); return 0;