p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ieee802154/adf7242: fix memory leak of firmware 

If the firmware upload or the firmware verification fails then we
printed the error message and exited but we missed releasing the
firmware.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
This commit is contained in:
Sudip Mukherjee 2016-04-07 16:46:04 +05:30 committed by Marcel Holtmann
parent feb2add323
commit cd9d7213d5
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ieee802154/adf7242.c
View File

@ -1030,6 +1030,7 @@ static int adf7242_hw_init(struct adf7242_local *lp)
if (ret) { if (ret) {
dev_err(&lp->spi->dev, dev_err(&lp->spi->dev,
"upload firmware failed with %d\n", ret); "upload firmware failed with %d\n", ret);
release_firmware(fw);
return ret; return ret;
} }
@ -1037,6 +1038,7 @@ static int adf7242_hw_init(struct adf7242_local *lp)
if (ret) { if (ret) {
dev_err(&lp->spi->dev, dev_err(&lp->spi->dev,
"verify firmware failed with %d\n", ret); "verify firmware failed with %d\n", ret);
release_firmware(fw);
return ret; return ret;
} }