p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

firmware: vpd: avoid potential use-after-free when destroying section 

We should not free info->key before we remove sysfs attribute that uses
this data as its name.

Fixes: 049a59db34 ("firmware: Google VPD sysfs driver")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dmitry Torokhov 2017-05-23 17:07:43 -07:00 committed by Greg Kroah-Hartman
parent 7f53de2069
commit ce57cba37f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/firmware/google/vpd.c
View File

@ -158,8 +158,8 @@ static void vpd_section_attrib_destroy(struct vpd_section *sec)
struct vpd_attrib_info *temp; struct vpd_attrib_info *temp;
list_for_each_entry_safe(info, temp, &sec->attribs, list) { list_for_each_entry_safe(info, temp, &sec->attribs, list) {
kfree(info->key);
sysfs_remove_bin_file(sec->kobj, &info->bin_attr); sysfs_remove_bin_file(sec->kobj, &info->bin_attr);
kfree(info->key);
kfree(info); kfree(info);
} }
} }