p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net: caif: check return value of alloc_netdev 

I don't know if dev can actually be NULL here, but the test should be
above alloc_netdev(), to avoid leaking the struct net_device in case
dev is actually NULL. And of course the return value from alloc_netdev
should be tested.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Rasmus Villemoes 2015-11-09 13:19:10 +01:00 committed by David S. Miller
parent 3870502a66
commit cfb76d77c0
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/caif/caif_spi.c
View File

@ -730,11 +730,14 @@ int cfspi_spi_probe(struct platform_device *pdev)
int res; int res;
dev = (struct cfspi_dev *)pdev->dev.platform_data; dev = (struct cfspi_dev *)pdev->dev.platform_data;
ndev = alloc_netdev(sizeof(struct cfspi), "cfspi%d",
NET_NAME_UNKNOWN, cfspi_setup);
if (!dev) if (!dev)
return -ENODEV; return -ENODEV;
ndev = alloc_netdev(sizeof(struct cfspi), "cfspi%d",
NET_NAME_UNKNOWN, cfspi_setup);
if (!ndev)
return -ENOMEM;
cfspi = netdev_priv(ndev); cfspi = netdev_priv(ndev);
netif_stop_queue(ndev); netif_stop_queue(ndev);
cfspi->ndev = ndev; cfspi->ndev = ndev;