samples/bpf: adapt samples/bpf to bpf_xdp_xxx() APIs

Use new bpf_xdp_*() APIs across all XDP-related BPF samples.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20220120061422.2710637-5-andrii@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
This commit is contained in:
Andrii Nakryiko 2022-01-19 22:14:22 -08:00 committed by Alexei Starovoitov
parent 544356524d
commit d4e34bfcbe
11 changed files with 40 additions and 41 deletions

View File

@ -26,12 +26,12 @@ static void int_exit(int sig)
{ {
__u32 curr_prog_id = 0; __u32 curr_prog_id = 0;
if (bpf_get_link_xdp_id(ifindex, &curr_prog_id, xdp_flags)) { if (bpf_xdp_query_id(ifindex, xdp_flags, &curr_prog_id)) {
printf("bpf_get_link_xdp_id failed\n"); printf("bpf_xdp_query_id failed\n");
exit(1); exit(1);
} }
if (prog_id == curr_prog_id) if (prog_id == curr_prog_id)
bpf_set_link_xdp_fd(ifindex, -1, xdp_flags); bpf_xdp_detach(ifindex, xdp_flags, NULL);
else if (!curr_prog_id) else if (!curr_prog_id)
printf("couldn't find a prog id on a given interface\n"); printf("couldn't find a prog id on a given interface\n");
else else
@ -143,7 +143,7 @@ int main(int argc, char **argv)
signal(SIGINT, int_exit); signal(SIGINT, int_exit);
signal(SIGTERM, int_exit); signal(SIGTERM, int_exit);
if (bpf_set_link_xdp_fd(ifindex, prog_fd, xdp_flags) < 0) { if (bpf_xdp_attach(ifindex, prog_fd, xdp_flags, NULL) < 0) {
printf("link set xdp fd failed\n"); printf("link set xdp fd failed\n");
return 1; return 1;
} }

View File

@ -34,12 +34,12 @@ static void int_exit(int sig)
__u32 curr_prog_id = 0; __u32 curr_prog_id = 0;
if (ifindex > -1) { if (ifindex > -1) {
if (bpf_get_link_xdp_id(ifindex, &curr_prog_id, xdp_flags)) { if (bpf_xdp_query_id(ifindex, xdp_flags, &curr_prog_id)) {
printf("bpf_get_link_xdp_id failed\n"); printf("bpf_xdp_query_id failed\n");
exit(1); exit(1);
} }
if (prog_id == curr_prog_id) if (prog_id == curr_prog_id)
bpf_set_link_xdp_fd(ifindex, -1, xdp_flags); bpf_xdp_detach(ifindex, xdp_flags, NULL);
else if (!curr_prog_id) else if (!curr_prog_id)
printf("couldn't find a prog id on a given iface\n"); printf("couldn't find a prog id on a given iface\n");
else else
@ -173,7 +173,7 @@ int main(int argc, char **argv)
signal(SIGINT, int_exit); signal(SIGINT, int_exit);
signal(SIGTERM, int_exit); signal(SIGTERM, int_exit);
if (bpf_set_link_xdp_fd(ifindex, prog_fd, xdp_flags) < 0) { if (bpf_xdp_attach(ifindex, prog_fd, xdp_flags, NULL) < 0) {
printf("link set xdp fd failed\n"); printf("link set xdp fd failed\n");
return 1; return 1;
} }

View File

@ -33,7 +33,7 @@ static int do_attach(int idx, int prog_fd, int map_fd, const char *name)
{ {
int err; int err;
err = bpf_set_link_xdp_fd(idx, prog_fd, xdp_flags); err = bpf_xdp_attach(idx, prog_fd, xdp_flags, NULL);
if (err < 0) { if (err < 0) {
printf("ERROR: failed to attach program to %s\n", name); printf("ERROR: failed to attach program to %s\n", name);
return err; return err;
@ -51,7 +51,7 @@ static int do_detach(int idx, const char *name)
{ {
int err; int err;
err = bpf_set_link_xdp_fd(idx, -1, xdp_flags); err = bpf_xdp_detach(idx, xdp_flags, NULL);
if (err < 0) if (err < 0)
printf("ERROR: failed to detach program from %s\n", name); printf("ERROR: failed to detach program from %s\n", name);

View File

@ -43,13 +43,13 @@ static void int_exit(int sig)
int i = 0; int i = 0;
for (i = 0; i < total_ifindex; i++) { for (i = 0; i < total_ifindex; i++) {
if (bpf_get_link_xdp_id(ifindex_list[i], &prog_id, flags)) { if (bpf_xdp_query_id(ifindex_list[i], flags, &prog_id)) {
printf("bpf_get_link_xdp_id on iface %d failed\n", printf("bpf_xdp_query_id on iface %d failed\n",
ifindex_list[i]); ifindex_list[i]);
exit(1); exit(1);
} }
if (prog_id_list[i] == prog_id) if (prog_id_list[i] == prog_id)
bpf_set_link_xdp_fd(ifindex_list[i], -1, flags); bpf_xdp_detach(ifindex_list[i], flags, NULL);
else if (!prog_id) else if (!prog_id)
printf("couldn't find a prog id on iface %d\n", printf("couldn't find a prog id on iface %d\n",
ifindex_list[i]); ifindex_list[i]);
@ -716,12 +716,12 @@ int main(int ac, char **argv)
} }
prog_id_list = (__u32 *)calloc(total_ifindex, sizeof(__u32 *)); prog_id_list = (__u32 *)calloc(total_ifindex, sizeof(__u32 *));
for (i = 0; i < total_ifindex; i++) { for (i = 0; i < total_ifindex; i++) {
if (bpf_set_link_xdp_fd(ifindex_list[i], prog_fd, flags) < 0) { if (bpf_xdp_attach(ifindex_list[i], prog_fd, flags, NULL) < 0) {
printf("link set xdp fd failed\n"); printf("link set xdp fd failed\n");
int recovery_index = i; int recovery_index = i;
for (i = 0; i < recovery_index; i++) for (i = 0; i < recovery_index; i++)
bpf_set_link_xdp_fd(ifindex_list[i], -1, flags); bpf_xdp_detach(ifindex_list[i], flags, NULL);
return 1; return 1;
} }

View File

@ -62,15 +62,15 @@ static void int_exit(int sig)
__u32 curr_prog_id = 0; __u32 curr_prog_id = 0;
if (ifindex > -1) { if (ifindex > -1) {
if (bpf_get_link_xdp_id(ifindex, &curr_prog_id, xdp_flags)) { if (bpf_xdp_query_id(ifindex, xdp_flags, &curr_prog_id)) {
printf("bpf_get_link_xdp_id failed\n"); printf("bpf_xdp_query_id failed\n");
exit(EXIT_FAIL); exit(EXIT_FAIL);
} }
if (prog_id == curr_prog_id) { if (prog_id == curr_prog_id) {
fprintf(stderr, fprintf(stderr,
"Interrupted: Removing XDP program on ifindex:%d device:%s\n", "Interrupted: Removing XDP program on ifindex:%d device:%s\n",
ifindex, ifname); ifindex, ifname);
bpf_set_link_xdp_fd(ifindex, -1, xdp_flags); bpf_xdp_detach(ifindex, xdp_flags, NULL);
} else if (!curr_prog_id) { } else if (!curr_prog_id) {
printf("couldn't find a prog id on a given iface\n"); printf("couldn't find a prog id on a given iface\n");
} else { } else {
@ -582,7 +582,7 @@ int main(int argc, char **argv)
signal(SIGINT, int_exit); signal(SIGINT, int_exit);
signal(SIGTERM, int_exit); signal(SIGTERM, int_exit);
if (bpf_set_link_xdp_fd(ifindex, prog_fd, xdp_flags) < 0) { if (bpf_xdp_attach(ifindex, prog_fd, xdp_flags, NULL) < 0) {
fprintf(stderr, "link set xdp fd failed\n"); fprintf(stderr, "link set xdp fd failed\n");
return EXIT_FAIL_XDP; return EXIT_FAIL_XDP;
} }

View File

@ -30,7 +30,7 @@ static int do_attach(int idx, int fd, const char *name)
__u32 info_len = sizeof(info); __u32 info_len = sizeof(info);
int err; int err;
err = bpf_set_link_xdp_fd(idx, fd, xdp_flags); err = bpf_xdp_attach(idx, fd, xdp_flags, NULL);
if (err < 0) { if (err < 0) {
printf("ERROR: failed to attach program to %s\n", name); printf("ERROR: failed to attach program to %s\n", name);
return err; return err;
@ -51,13 +51,13 @@ static int do_detach(int idx, const char *name)
__u32 curr_prog_id = 0; __u32 curr_prog_id = 0;
int err = 0; int err = 0;
err = bpf_get_link_xdp_id(idx, &curr_prog_id, xdp_flags); err = bpf_xdp_query_id(idx, xdp_flags, &curr_prog_id);
if (err) { if (err) {
printf("bpf_get_link_xdp_id failed\n"); printf("bpf_xdp_query_id failed\n");
return err; return err;
} }
if (prog_id == curr_prog_id) { if (prog_id == curr_prog_id) {
err = bpf_set_link_xdp_fd(idx, -1, xdp_flags); err = bpf_xdp_detach(idx, xdp_flags, NULL);
if (err < 0) if (err < 0)
printf("ERROR: failed to detach prog from %s\n", name); printf("ERROR: failed to detach prog from %s\n", name);
} else if (!curr_prog_id) { } else if (!curr_prog_id) {

View File

@ -1265,7 +1265,7 @@ static int __sample_remove_xdp(int ifindex, __u32 prog_id, int xdp_flags)
int ret; int ret;
if (prog_id) { if (prog_id) {
ret = bpf_get_link_xdp_id(ifindex, &cur_prog_id, xdp_flags); ret = bpf_xdp_query_id(ifindex, xdp_flags, &cur_prog_id);
if (ret < 0) if (ret < 0)
return -errno; return -errno;
@ -1278,7 +1278,7 @@ static int __sample_remove_xdp(int ifindex, __u32 prog_id, int xdp_flags)
} }
} }
return bpf_set_link_xdp_fd(ifindex, -1, xdp_flags); return bpf_xdp_detach(ifindex, xdp_flags, NULL);
} }
int sample_install_xdp(struct bpf_program *xdp_prog, int ifindex, bool generic, int sample_install_xdp(struct bpf_program *xdp_prog, int ifindex, bool generic,
@ -1295,8 +1295,7 @@ int sample_install_xdp(struct bpf_program *xdp_prog, int ifindex, bool generic,
xdp_flags |= !force ? XDP_FLAGS_UPDATE_IF_NOEXIST : 0; xdp_flags |= !force ? XDP_FLAGS_UPDATE_IF_NOEXIST : 0;
xdp_flags |= generic ? XDP_FLAGS_SKB_MODE : XDP_FLAGS_DRV_MODE; xdp_flags |= generic ? XDP_FLAGS_SKB_MODE : XDP_FLAGS_DRV_MODE;
ret = bpf_set_link_xdp_fd(ifindex, bpf_program__fd(xdp_prog), ret = bpf_xdp_attach(ifindex, bpf_program__fd(xdp_prog), xdp_flags, NULL);
xdp_flags);
if (ret < 0) { if (ret < 0) {
ret = -errno; ret = -errno;
fprintf(stderr, fprintf(stderr,
@ -1308,7 +1307,7 @@ int sample_install_xdp(struct bpf_program *xdp_prog, int ifindex, bool generic,
return ret; return ret;
} }
ret = bpf_get_link_xdp_id(ifindex, &prog_id, xdp_flags); ret = bpf_xdp_query_id(ifindex, xdp_flags, &prog_id);
if (ret < 0) { if (ret < 0) {
ret = -errno; ret = -errno;
fprintf(stderr, fprintf(stderr,

View File

@ -32,12 +32,12 @@ static void int_exit(int sig)
__u32 curr_prog_id = 0; __u32 curr_prog_id = 0;
if (ifindex > -1) { if (ifindex > -1) {
if (bpf_get_link_xdp_id(ifindex, &curr_prog_id, xdp_flags)) { if (bpf_xdp_query_id(ifindex, xdp_flags, &curr_prog_id)) {
printf("bpf_get_link_xdp_id failed\n"); printf("bpf_xdp_query_id failed\n");
exit(1); exit(1);
} }
if (prog_id == curr_prog_id) if (prog_id == curr_prog_id)
bpf_set_link_xdp_fd(ifindex, -1, xdp_flags); bpf_xdp_detach(ifindex, xdp_flags, NULL);
else if (!curr_prog_id) else if (!curr_prog_id)
printf("couldn't find a prog id on a given iface\n"); printf("couldn't find a prog id on a given iface\n");
else else
@ -288,7 +288,7 @@ int main(int argc, char **argv)
} }
} }
if (bpf_set_link_xdp_fd(ifindex, prog_fd, xdp_flags) < 0) { if (bpf_xdp_attach(ifindex, prog_fd, xdp_flags, NULL) < 0) {
printf("link set xdp fd failed\n"); printf("link set xdp fd failed\n");
return 1; return 1;
} }
@ -302,7 +302,7 @@ int main(int argc, char **argv)
poll_stats(kill_after_s); poll_stats(kill_after_s);
bpf_set_link_xdp_fd(ifindex, -1, xdp_flags); bpf_xdp_detach(ifindex, xdp_flags, NULL);
return 0; return 0;
} }

View File

@ -173,7 +173,7 @@ main(int argc, char **argv)
unlink(SOCKET_NAME); unlink(SOCKET_NAME);
/* Unset fd for given ifindex */ /* Unset fd for given ifindex */
err = bpf_set_link_xdp_fd(ifindex, -1, 0); err = bpf_xdp_detach(ifindex, 0, NULL);
if (err) { if (err) {
fprintf(stderr, "Error when unsetting bpf prog_fd for ifindex(%d)\n", ifindex); fprintf(stderr, "Error when unsetting bpf prog_fd for ifindex(%d)\n", ifindex);
return err; return err;

View File

@ -571,13 +571,13 @@ static void remove_xdp_program(void)
{ {
u32 curr_prog_id = 0; u32 curr_prog_id = 0;
if (bpf_get_link_xdp_id(opt_ifindex, &curr_prog_id, opt_xdp_flags)) { if (bpf_xdp_query_id(opt_ifindex, opt_xdp_flags, &curr_prog_id)) {
printf("bpf_get_link_xdp_id failed\n"); printf("bpf_xdp_query_id failed\n");
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }
if (prog_id == curr_prog_id) if (prog_id == curr_prog_id)
bpf_set_link_xdp_fd(opt_ifindex, -1, opt_xdp_flags); bpf_xdp_detach(opt_ifindex, opt_xdp_flags, NULL);
else if (!curr_prog_id) else if (!curr_prog_id)
printf("couldn't find a prog id on a given interface\n"); printf("couldn't find a prog id on a given interface\n");
else else
@ -1027,7 +1027,7 @@ static struct xsk_socket_info *xsk_configure_socket(struct xsk_umem_info *umem,
if (ret) if (ret)
exit_with_error(-ret); exit_with_error(-ret);
ret = bpf_get_link_xdp_id(opt_ifindex, &prog_id, opt_xdp_flags); ret = bpf_xdp_query_id(opt_ifindex, opt_xdp_flags, &prog_id);
if (ret) if (ret)
exit_with_error(-ret); exit_with_error(-ret);
@ -1760,7 +1760,7 @@ static void load_xdp_program(char **argv, struct bpf_object **obj)
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }
if (bpf_set_link_xdp_fd(opt_ifindex, prog_fd, opt_xdp_flags) < 0) { if (bpf_xdp_attach(opt_ifindex, prog_fd, opt_xdp_flags, NULL) < 0) {
fprintf(stderr, "ERROR: link set xdp fd failed\n"); fprintf(stderr, "ERROR: link set xdp fd failed\n");
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }

View File

@ -974,8 +974,8 @@ static void remove_xdp_program(void)
int i; int i;
for (i = 0 ; i < n_ports; i++) for (i = 0 ; i < n_ports; i++)
bpf_set_link_xdp_fd(if_nametoindex(port_params[i].iface), -1, bpf_xdp_detach(if_nametoindex(port_params[i].iface),
port_params[i].xsk_cfg.xdp_flags); port_params[i].xsk_cfg.xdp_flags, NULL);
} }
int main(int argc, char **argv) int main(int argc, char **argv)