p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cpufreq: integrator: fix integrator_cpufreq_remove return type 

When building this driver as a module, we get a helpful warning
about the return type:

drivers/cpufreq/integrator-cpufreq.c:232:2: warning: initialization from incompatible pointer type
  .remove = __exit_p(integrator_cpufreq_remove),

If the remove callback returns void, the caller gets an undefined
value as it expects an integer to be returned. This fixes the
problem by passing down the value from cpufreq_unregister_driver.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Arnd Bergmann 2014-09-26 22:19:12 +02:00 committed by Rafael J. Wysocki
parent e65b5ddba8
commit d62dbf77f7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/cpufreq/integrator-cpufreq.c
View File

@ -213,9 +213,9 @@ static int __init integrator_cpufreq_probe(struct platform_device *pdev)
return cpufreq_register_driver(&integrator_driver); return cpufreq_register_driver(&integrator_driver);
} }
static void __exit integrator_cpufreq_remove(struct platform_device *pdev) static int __exit integrator_cpufreq_remove(struct platform_device *pdev)
{ {
cpufreq_unregister_driver(&integrator_driver); return cpufreq_unregister_driver(&integrator_driver);
} }
static const struct of_device_id integrator_cpufreq_match[] = { static const struct of_device_id integrator_cpufreq_match[] = {