p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

crypto: chtls - use 64-bit arithmetic instead of 32-bit 

Cast *val* to u64 in order to give the compiler complete
information about the proper arithmetic to use.

Notice that such variable is used in a context that expects an
expression of type u64 (64 bits, unsigned) and the following
expression is currently being evaluated using 32-bit arithmetic:

val << bit_pos

Addresses-Coverity-ID: 1467425 ("Unintentional integer overflow")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Gustavo A. R. Silva 2018-07-04 11:37:20 -05:00 committed by Herbert Xu
parent dcbc0c6e4a
commit d6be72ee2c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/crypto/chelsio/chtls/chtls_hw.c
View File

@ -97,7 +97,7 @@ static int chtls_set_tcb_field(struct sock *sk, u16 word, u64 mask, u64 val)
int chtls_set_tcb_tflag(struct sock *sk, unsigned int bit_pos, int val) int chtls_set_tcb_tflag(struct sock *sk, unsigned int bit_pos, int val)
{ {
return chtls_set_tcb_field(sk, 1, 1ULL << bit_pos, return chtls_set_tcb_field(sk, 1, 1ULL << bit_pos,
val << bit_pos); (u64)val << bit_pos);
} }
static int chtls_set_tcb_keyid(struct sock *sk, int keyid) static int chtls_set_tcb_keyid(struct sock *sk, int keyid)