p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

s390: pci: no need to check return value of debugfs_create functions 

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Sebastian Ott <sebott@linux.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sebastian Ott <sebott@linux.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Greg Kroah-Hartman 2019-01-22 16:21:01 +01:00 committed by Martin Schwidefsky
parent f36108c462
commit d7f2f7c7fc
2 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
arch/s390/include/asm/pci.h
View File

@ -148,7 +148,6 @@ struct zpci_dev {
enum pci_bus_speed max_bus_speed; enum pci_bus_speed max_bus_speed;
struct dentry *debugfs_dev; struct dentry *debugfs_dev;
struct dentry *debugfs_perf;
struct s390_domain *s390_domain; /* s390 IOMMU domain data */ struct s390_domain *s390_domain; /* s390 IOMMU domain data */
}; };

13
arch/s390/pci/pci_debug.c
View File

@ -172,21 +172,14 @@ static const struct file_operations debugfs_pci_perf_fops = {
void zpci_debug_init_device(struct zpci_dev *zdev, const char *name) void zpci_debug_init_device(struct zpci_dev *zdev, const char *name)
{ {
zdev->debugfs_dev = debugfs_create_dir(name, debugfs_root); zdev->debugfs_dev = debugfs_create_dir(name, debugfs_root);
if (IS_ERR(zdev->debugfs_dev))
zdev->debugfs_dev = NULL;
zdev->debugfs_perf = debugfs_create_file("statistics", debugfs_create_file("statistics", S_IFREG | S_IRUGO | S_IWUSR,
S_IFREG | S_IRUGO | S_IWUSR, zdev->debugfs_dev, zdev, &debugfs_pci_perf_fops);
zdev->debugfs_dev, zdev,
&debugfs_pci_perf_fops);
if (IS_ERR(zdev->debugfs_perf))
zdev->debugfs_perf = NULL;
} }
void zpci_debug_exit_device(struct zpci_dev *zdev) void zpci_debug_exit_device(struct zpci_dev *zdev)
{ {
debugfs_remove(zdev->debugfs_perf); debugfs_remove_recursive(zdev->debugfs_dev);
debugfs_remove(zdev->debugfs_dev);
} }
int __init zpci_debug_init(void) int __init zpci_debug_init(void)