p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

IB/rxe: avoid calling WARN_ON_ONCE twice 

In the exit branch, WARN_ON_ONCE is called to show stack. So it is
not necessary to call WARN_ON_ONCE before going to exit.

Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Zhu Yanjun 2018-05-17 04:55:22 -04:00 committed by Jason Gunthorpe
parent 5e6e78dbd3
commit da2f3b286a
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/infiniband/sw/rxe/rxe_comp.c
View File

@ -659,7 +659,6 @@ int rxe_completer(void *arg)
qp->qp_timeout_jiffies) qp->qp_timeout_jiffies)
mod_timer(&qp->retrans_timer, mod_timer(&qp->retrans_timer,
jiffies + qp->qp_timeout_jiffies); jiffies + qp->qp_timeout_jiffies);
WARN_ON_ONCE(skb);
goto exit; goto exit;
case COMPST_ERROR_RETRY: case COMPST_ERROR_RETRY:
@ -673,7 +672,6 @@ int rxe_completer(void *arg)
/* there is nothing to retry in this case */ /* there is nothing to retry in this case */
if (!wqe || (wqe->state == wqe_state_posted)) { if (!wqe || (wqe->state == wqe_state_posted)) {
WARN_ON_ONCE(skb);
goto exit; goto exit;
} }
@ -702,7 +700,6 @@ int rxe_completer(void *arg)
skb = NULL; skb = NULL;
} }
WARN_ON_ONCE(skb);
goto exit; goto exit;
} else { } else {
@ -746,7 +743,6 @@ int rxe_completer(void *arg)
skb = NULL; skb = NULL;
} }
WARN_ON_ONCE(skb);
goto exit; goto exit;
} }
} }