p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

serial: core: Claim port mutex for set_ldisc() 

Three UART drivers (8250, atmel & amba-pl010) enable modem status
interrupts if the line discipline is changed to N_PPS. However,
the uart port flags may only be safely modified while holding the
port mutex.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Peter Hurley 2014-11-05 13:11:42 -05:00 committed by Greg Kroah-Hartman
parent 9191aaaa82
commit db1b9dfcd6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/tty/serial/serial_core.c
View File

@ -1245,8 +1245,11 @@ static void uart_set_ldisc(struct tty_struct *tty)
struct uart_state *state = tty->driver_data;
struct uart_port *uport = state->uart_port;
if (uport->ops->set_ldisc)
if (uport->ops->set_ldisc) {
mutex_lock(&state->port.mutex);
uport->ops->set_ldisc(uport, tty->termios.c_line);
mutex_unlock(&state->port.mutex);
}
}
static void uart_set_termios(struct tty_struct *tty,