p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

xen/privcmd: return -ENOTTY for unimplemented IOCTLs 

The code sets the default return code to -ENOSYS but then overrides this
to -EINVAL in the switch() statement's default case, which is clearly
silly.

This patch removes the override and sets the default return code to
-ENOTTY, which is the conventional return for an unimplemented ioctl.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
This commit is contained in:
Paul Durrant 2017-02-13 17:03:22 +00:00 committed by Boris Ostrovsky
parent fd8aa9095a
commit dc9eab6fd9
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/xen/privcmd.c
View File

@ -551,7 +551,7 @@ static long privcmd_ioctl_mmap_batch(void __user *udata, int version)
static long privcmd_ioctl(struct file *file,
unsigned int cmd, unsigned long data)
{
int ret = -ENOSYS;
int ret = -ENOTTY;
void __user *udata = (void __user *) data;
switch (cmd) {
@ -572,7 +572,6 @@ static long privcmd_ioctl(struct file *file,
break;
default:
ret = -EINVAL;
break;
}