p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mei: bus: elminate variable length arrays 

Though VLA are supported by CC99 there are many cavities
and should be avoided.

'const size_t len = sizeof()' that we used may not be set
at the compile time hence generating VLA code.

This fixes also sparse warning
warning: Variable length array is used type.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tomas Winkler 2017-03-20 15:04:05 +02:00 committed by Greg Kroah-Hartman
parent 3fcbab6c4a
commit dd04eecc41
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/misc/mei/bus-fixup.c
View File

@ -110,12 +110,13 @@ struct mkhi_msg {
u8 data[0]; u8 data[0];
} __packed; } __packed;
#define MKHI_OSVER_BUF_LEN (sizeof(struct mkhi_msg_hdr) + \
sizeof(struct mkhi_fwcaps) + \
sizeof(struct mei_os_ver))
static int mei_osver(struct mei_cl_device *cldev) static int mei_osver(struct mei_cl_device *cldev)
{ {
const size_t size = sizeof(struct mkhi_msg_hdr) + const size_t size = MKHI_OSVER_BUF_LEN;
sizeof(struct mkhi_fwcaps) + char buf[MKHI_OSVER_BUF_LEN];
sizeof(struct mei_os_ver);
char buf[size];
struct mkhi_msg *req; struct mkhi_msg *req;
struct mkhi_fwcaps *fwcaps; struct mkhi_fwcaps *fwcaps;
struct mei_os_ver *os_ver; struct mei_os_ver *os_ver;