p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

netfilter: nf_tables: release objects on netns destruction 

We have to release the existing objects on netns removal otherwise we
leak them. Chains are unregistered in first place to make sure no
packets are walking on our rules and sets anymore.

The object release happens by when we unregister the family via
nft_release_afinfo() which is called from nft_unregister_afinfo() from
the corresponding __net_exit path in every family.

Reported-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
Pablo Neira Ayuso 2015-12-15 19:39:32 +01:00
parent 26a4d063b1
commit df05ef874b
8 changed files with 52 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/net/netfilter/nf_tables.h
View File

@ -880,7 +880,7 @@ struct nft_af_info {
};
int nft_register_afinfo(struct net *, struct nft_af_info *);
void nft_unregister_afinfo(struct nft_af_info *);
void nft_unregister_afinfo(struct net *, struct nft_af_info *);
int nft_register_chain_type(const struct nf_chain_type *);
void nft_unregister_chain_type(const struct nf_chain_type *);

2
net/bridge/netfilter/nf_tables_bridge.c
View File

@ -141,7 +141,7 @@ static int nf_tables_bridge_init_net(struct net *net)
static void nf_tables_bridge_exit_net(struct net *net)
{
nft_unregister_afinfo(net->nft.bridge);
nft_unregister_afinfo(net, net->nft.bridge);
kfree(net->nft.bridge);
}

2
net/ipv4/netfilter/nf_tables_arp.c
View File

@ -57,7 +57,7 @@ static int nf_tables_arp_init_net(struct net *net)
static void nf_tables_arp_exit_net(struct net *net)
{
nft_unregister_afinfo(net->nft.arp);
nft_unregister_afinfo(net, net->nft.arp);
kfree(net->nft.arp);
}

2
net/ipv4/netfilter/nf_tables_ipv4.c
View File

@ -78,7 +78,7 @@ static int nf_tables_ipv4_init_net(struct net *net)
static void nf_tables_ipv4_exit_net(struct net *net)
{
nft_unregister_afinfo(net->nft.ipv4);
nft_unregister_afinfo(net, net->nft.ipv4);
kfree(net->nft.ipv4);
}

2
net/ipv6/netfilter/nf_tables_ipv6.c
View File

@ -77,7 +77,7 @@ static int nf_tables_ipv6_init_net(struct net *net)
static void nf_tables_ipv6_exit_net(struct net *net)
{
nft_unregister_afinfo(net->nft.ipv6);
nft_unregister_afinfo(net, net->nft.ipv6);
kfree(net->nft.ipv6);
}

47
net/netfilter/nf_tables_api.c
View File

@ -41,6 +41,8 @@ int nft_register_afinfo(struct net *net, struct nft_af_info *afi)
}
EXPORT_SYMBOL_GPL(nft_register_afinfo);
static void __nft_release_afinfo(struct net *net, struct nft_af_info *afi);
/**
* nft_unregister_afinfo - unregister nf_tables address family info
*
@ -48,9 +50,10 @@ EXPORT_SYMBOL_GPL(nft_register_afinfo);
*
* Unregister the address family for use with nf_tables.
*/
void nft_unregister_afinfo(struct nft_af_info *afi)
void nft_unregister_afinfo(struct net *net, struct nft_af_info *afi)
{
nfnl_lock(NFNL_SUBSYS_NFTABLES);
__nft_release_afinfo(net, afi);
list_del_rcu(&afi->list);
nfnl_unlock(NFNL_SUBSYS_NFTABLES);
}
@ -4579,7 +4582,7 @@ int nft_data_dump(struct sk_buff *skb, int attr, const struct nft_data *data,
}
EXPORT_SYMBOL_GPL(nft_data_dump);
static int nf_tables_init_net(struct net *net)
static int __net_init nf_tables_init_net(struct net *net)
{
INIT_LIST_HEAD(&net->nft.af_info);
INIT_LIST_HEAD(&net->nft.commit_list);
@ -4587,6 +4590,46 @@ static int nf_tables_init_net(struct net *net)
return 0;
}
/* Called by nft_unregister_afinfo() from __net_exit path, nfnl_lock is held. */
static void __nft_release_afinfo(struct net *net, struct nft_af_info *afi)
{
struct nft_table *table, *nt;
struct nft_chain *chain, *nc;
struct nft_rule *rule, *nr;
struct nft_set *set, *ns;
struct nft_ctx ctx = {
.net = net,
.afi = afi,
};
list_for_each_entry_safe(table, nt, &afi->tables, list) {
list_for_each_entry(chain, &table->chains, list)
nf_tables_unregister_hooks(table, chain, afi->nops);
/* No packets are walking on these chains anymore. */
ctx.table = table;
list_for_each_entry(chain, &table->chains, list) {
ctx.chain = chain;
list_for_each_entry_safe(rule, nr, &chain->rules, list) {
list_del(&rule->list);
chain->use--;
nf_tables_rule_destroy(&ctx, rule);
}
}
list_for_each_entry_safe(set, ns, &table->sets, list) {
list_del(&set->list);
table->use--;
nft_set_destroy(set);
}
list_for_each_entry_safe(chain, nc, &table->chains, list) {
list_del(&chain->list);
table->use--;
nf_tables_chain_destroy(chain);
}
list_del(&table->list);
nf_tables_table_destroy(&ctx);
}
}
static struct pernet_operations nf_tables_net_ops = {
.init = nf_tables_init_net,
};

2
net/netfilter/nf_tables_inet.c
View File

@ -57,7 +57,7 @@ static int __net_init nf_tables_inet_init_net(struct net *net)
static void __net_exit nf_tables_inet_exit_net(struct net *net)
{
nft_unregister_afinfo(net->nft.inet);
nft_unregister_afinfo(net, net->nft.inet);
kfree(net->nft.inet);
}

2
net/netfilter/nf_tables_netdev.c
View File

@ -139,7 +139,7 @@ static int nf_tables_netdev_init_net(struct net *net)
static void nf_tables_netdev_exit_net(struct net *net)
{
nft_unregister_afinfo(net->nft.netdev);
nft_unregister_afinfo(net, net->nft.netdev);
kfree(net->nft.netdev);
}