p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sunvnet: Add missing rcu_read_unlock() in vnet_start_xmit 

The out_dropped label will only do rcu_read_unlock for non-null port.
So add the missing rcu_read_unlock() when bailing due to non-null port.

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sowmini Varadhan 2014-11-08 20:42:20 -05:00 committed by David S. Miller
parent 777362d721
commit df20286ab1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/sun/sunvnet.c
View File

@ -981,8 +981,10 @@ static int vnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
rcu_read_lock();
port = __tx_port_find(vp, skb);
if (unlikely(!port))
if (unlikely(!port)) {
rcu_read_unlock();
goto out_dropped;
}
if (skb->len > port->rmtu) {
unsigned long localmtu = port->rmtu - ETH_HLEN;