p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ubifs: Fail commit if TNC is obviously inconsistent 

A reference to LEB 0 or with length 0 in the TNC
is never correct and could be caused by a memory corruption.
Don't write such a bad index node to the MTD.
Instead fail the commit which will turn UBIFS into read-only mode.

This is less painful than having the bad reference on the MTD
from where UBFIS has no chance to recover.

Signed-off-by: Richard Weinberger <richard@nod.at>
This commit is contained in:
Richard Weinberger 2017-06-07 23:33:35 +02:00
parent 319c104274
commit df71b09145
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ubifs/tnc_commit.c
View File

@ -57,6 +57,8 @@ static int make_idx_node(struct ubifs_info *c, struct ubifs_idx_node *idx,
ubifs_dump_znode(c, znode); ubifs_dump_znode(c, znode);
if (zbr->znode) if (zbr->znode)
ubifs_dump_znode(c, zbr->znode); ubifs_dump_znode(c, zbr->znode);
return -EINVAL;
} }
} }
ubifs_prepare_node(c, idx, len, 0); ubifs_prepare_node(c, idx, len, 0);
@ -859,6 +861,8 @@ static int write_index(struct ubifs_info *c)
ubifs_dump_znode(c, znode); ubifs_dump_znode(c, znode);
if (zbr->znode) if (zbr->znode)
ubifs_dump_znode(c, zbr->znode); ubifs_dump_znode(c, zbr->znode);
return -EINVAL;
} }
} }
len = ubifs_idx_node_sz(c, znode->child_cnt); len = ubifs_idx_node_sz(c, znode->child_cnt);