p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dm zoned: fix potential NULL dereference in dmz_do_reclaim() 

This function is supposed to return error pointers so it matches the
dmz_get_rnd_zone_for_reclaim() function.  The current code could lead to
a NULL dereference in dmz_do_reclaim()

Fixes: b234c6d7a7 ("dm zoned: improve error handling in reclaim")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
Dan Carpenter 2019-08-19 12:58:14 +03:00 committed by Mike Snitzer
parent 08c04c84a5
commit e0702d90b7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/md/dm-zoned-metadata.c
View File

@ -1588,7 +1588,7 @@ static struct dm_zone *dmz_get_seq_zone_for_reclaim(struct dmz_metadata *zmd)
struct dm_zone *zone; struct dm_zone *zone;
if (list_empty(&zmd->map_seq_list)) if (list_empty(&zmd->map_seq_list))
return NULL; return ERR_PTR(-EBUSY);
list_for_each_entry(zone, &zmd->map_seq_list, link) { list_for_each_entry(zone, &zmd->map_seq_list, link) {
if (!zone->bzone) if (!zone->bzone)
@ -1597,7 +1597,7 @@ static struct dm_zone *dmz_get_seq_zone_for_reclaim(struct dmz_metadata *zmd)
return zone; return zone;
} }
return NULL; return ERR_PTR(-EBUSY);
} }
/* /*