p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

staging: binder: Fix death notifications 

The change (008fa749e0) that moved the
node release code to a separate function broke death notifications in
some cases. When it encountered a reference without a death
notification request, it would skip looking at the remaining
references, and therefore fail to send death notifications for them.

Cc: Colin Cross <ccross@android.com>
Cc: Android Kernel Team <kernel-team@android.com>
Cc: stable <stable@vger.kernel.org> # 3.10
Signed-off-by: Arve Hjønnevåg <arve@android.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Arve Hjønnevåg 2014-02-17 13:58:29 -08:00 committed by Greg Kroah-Hartman
parent 6d0abeca32
commit e194fd8a5d
1 changed files with 1 additions and 2 deletions
drivers/staging/android
binder.c

3
drivers/staging/android/binder.c
View File

@ -2904,7 +2904,7 @@ static int binder_node_release(struct binder_node *node, int refs)
refs++; refs++;
if (!ref->death) if (!ref->death)
goto out; continue;
death++; death++;
@ -2917,7 +2917,6 @@ static int binder_node_release(struct binder_node *node, int refs)
BUG(); BUG();
} }
out:
binder_debug(BINDER_DEBUG_DEAD_BINDER, binder_debug(BINDER_DEBUG_DEAD_BINDER,
"node %d now dead, refs %d, death %d\n", "node %d now dead, refs %d, death %d\n",
node->debug_id, refs, death); node->debug_id, refs, death);