p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

serial: bcm2835: fix unsigned int issue with irq 

Fixes error condition check when requesting the irq,
that would not trigger because of uart_port.irq being
defined as unsigned int.

Reported by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Martin Sperl 2016-02-09 11:47:16 +00:00 committed by Greg Kroah-Hartman
parent 0ab556c266
commit e1a7d24827
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/tty/serial/8250/8250_bcm2835aux.c
View File

@ -59,12 +59,12 @@ static int bcm2835aux_serial_probe(struct platform_device *pdev)
} }
/* get the interrupt */ /* get the interrupt */
data->uart.port.irq = platform_get_irq(pdev, 0); ret = platform_get_irq(pdev, 0);
if (data->uart.port.irq < 0) { if (ret < 0) {
dev_err(&pdev->dev, "irq not found - %i", dev_err(&pdev->dev, "irq not found - %i", ret);
data->uart.port.irq); return ret;
return data->uart.port.irq;
} }
data->uart.port.irq = ret;
/* map the main registers */ /* map the main registers */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);