p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net: ns83820: remove unnecessary pci_set_drvdata() 

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jingoo Han 2013-12-09 12:27:27 +09:00 committed by David S. Miller
parent add0cdb43a
commit e28f4d5951
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/natsemi/ns83820.c
View File

@ -2235,7 +2235,6 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
pci_disable_device(pci_dev); pci_disable_device(pci_dev);
out_free: out_free:
free_netdev(ndev); free_netdev(ndev);
pci_set_drvdata(pci_dev, NULL);
out: out:
return err; return err;
} }
@ -2259,7 +2258,6 @@ static void ns83820_remove_one(struct pci_dev *pci_dev)
dev->rx_info.descs, dev->rx_info.phy_descs); dev->rx_info.descs, dev->rx_info.phy_descs);
pci_disable_device(dev->pci_dev); pci_disable_device(dev->pci_dev);
free_netdev(ndev); free_netdev(ndev);
pci_set_drvdata(pci_dev, NULL);
} }
static DEFINE_PCI_DEVICE_TABLE(ns83820_pci_tbl) = { static DEFINE_PCI_DEVICE_TABLE(ns83820_pci_tbl) = {