p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

coresight: etm3: Add support for handling errors 

Add support for reporting errors back from the SMP cross
function call for enabling ETM.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Suzuki K Poulose 2018-09-20 13:18:08 -06:00 committed by Greg Kroah-Hartman
parent e006d89abe
commit e2a1551a88
1 changed files with 28 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
drivers/hwtracing/coresight/coresight-etm3x.c
View File

@ -355,11 +355,10 @@ static int etm_parse_event_config(struct etm_drvdata *drvdata,
return 0; return 0;
} }
static void etm_enable_hw(void *info) static int etm_enable_hw(struct etm_drvdata *drvdata)
{ {
int i; int i;
u32 etmcr; u32 etmcr;
struct etm_drvdata *drvdata = info;
struct etm_config *config = &drvdata->config; struct etm_config *config = &drvdata->config;
CS_UNLOCK(drvdata->base); CS_UNLOCK(drvdata->base);
@ -421,6 +420,21 @@ static void etm_enable_hw(void *info)
CS_LOCK(drvdata->base); CS_LOCK(drvdata->base);
dev_dbg(drvdata->dev, "cpu: %d enable smp call done\n", drvdata->cpu); dev_dbg(drvdata->dev, "cpu: %d enable smp call done\n", drvdata->cpu);
return 0;
}
struct etm_enable_arg {
struct etm_drvdata *drvdata;
int rc;
};
static void etm_enable_hw_smp_call(void *info)
{
struct etm_enable_arg *arg = info;
if (WARN_ON(!arg))
return;
arg->rc = etm_enable_hw(arg->drvdata);
} }
static int etm_cpu_id(struct coresight_device *csdev) static int etm_cpu_id(struct coresight_device *csdev)
@ -475,14 +489,13 @@ static int etm_enable_perf(struct coresight_device *csdev,
/* Configure the tracer based on the session's specifics */ /* Configure the tracer based on the session's specifics */
etm_parse_event_config(drvdata, event); etm_parse_event_config(drvdata, event);
/* And enable it */ /* And enable it */
etm_enable_hw(drvdata); return etm_enable_hw(drvdata);
return 0;
} }
static int etm_enable_sysfs(struct coresight_device *csdev) static int etm_enable_sysfs(struct coresight_device *csdev)
{ {
struct etm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent); struct etm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
struct etm_enable_arg arg = { 0 };
int ret; int ret;
spin_lock(&drvdata->spinlock); spin_lock(&drvdata->spinlock);
@ -492,20 +505,21 @@ static int etm_enable_sysfs(struct coresight_device *csdev)
* hw configuration will take place on the local CPU during bring up. * hw configuration will take place on the local CPU during bring up.
*/ */
if (cpu_online(drvdata->cpu)) { if (cpu_online(drvdata->cpu)) {
arg.drvdata = drvdata;
ret = smp_call_function_single(drvdata->cpu, ret = smp_call_function_single(drvdata->cpu,
etm_enable_hw, drvdata, 1); etm_enable_hw_smp_call, &arg, 1);
if (ret) if (!ret)
goto err; ret = arg.rc;
if (!ret)
drvdata->sticky_enable = true;
} else {
ret = -ENODEV;
} }
drvdata->sticky_enable = true;
spin_unlock(&drvdata->spinlock); spin_unlock(&drvdata->spinlock);
dev_dbg(drvdata->dev, "ETM tracing enabled\n"); if (!ret)
return 0; dev_dbg(drvdata->dev, "ETM tracing enabled\n");
err:
spin_unlock(&drvdata->spinlock);
return ret; return ret;
} }