p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

debugfs: remove return value of debugfs_create_x16() 

No one checks the return value of debugfs_create_x16(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Link: https://lore.kernel.org/r/20191011132931.1186197-6-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2019-10-11 15:29:29 +02:00
parent be5767341c
commit e40d38f28c
3 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/filesystems/debugfs.txt
View File

@ -84,8 +84,8 @@ the following functions can be used instead:
struct dentry *debugfs_create_x8(const char *name, umode_t mode, struct dentry *debugfs_create_x8(const char *name, umode_t mode,
struct dentry *parent, u8 *value); struct dentry *parent, u8 *value);
struct dentry *debugfs_create_x16(const char *name, umode_t mode, void debugfs_create_x16(const char *name, umode_t mode,
struct dentry *parent, u16 *value); struct dentry *parent, u16 *value);
struct dentry *debugfs_create_x32(const char *name, umode_t mode, struct dentry *debugfs_create_x32(const char *name, umode_t mode,
struct dentry *parent, u32 *value); struct dentry *parent, u32 *value);
struct dentry *debugfs_create_x64(const char *name, umode_t mode, struct dentry *debugfs_create_x64(const char *name, umode_t mode,

6
fs/debugfs/file.c
View File

@ -651,10 +651,10 @@ EXPORT_SYMBOL_GPL(debugfs_create_x8);
* @value: a pointer to the variable that the file should read to and write * @value: a pointer to the variable that the file should read to and write
* from. * from.
*/ */
struct dentry *debugfs_create_x16(const char *name, umode_t mode, void debugfs_create_x16(const char *name, umode_t mode, struct dentry *parent,
struct dentry *parent, u16 *value) u16 *value)
{ {
return debugfs_create_mode_unsafe(name, mode, parent, value, &fops_x16, debugfs_create_mode_unsafe(name, mode, parent, value, &fops_x16,
&fops_x16_ro, &fops_x16_wo); &fops_x16_ro, &fops_x16_wo);
} }
EXPORT_SYMBOL_GPL(debugfs_create_x16); EXPORT_SYMBOL_GPL(debugfs_create_x16);

12
include/linux/debugfs.h
View File

@ -109,8 +109,8 @@ struct dentry *debugfs_create_ulong(const char *name, umode_t mode,
struct dentry *parent, unsigned long *value); struct dentry *parent, unsigned long *value);
struct dentry *debugfs_create_x8(const char *name, umode_t mode, struct dentry *debugfs_create_x8(const char *name, umode_t mode,
struct dentry *parent, u8 *value); struct dentry *parent, u8 *value);
struct dentry *debugfs_create_x16(const char *name, umode_t mode, void debugfs_create_x16(const char *name, umode_t mode, struct dentry *parent,
struct dentry *parent, u16 *value); u16 *value);
struct dentry *debugfs_create_x32(const char *name, umode_t mode, struct dentry *debugfs_create_x32(const char *name, umode_t mode,
struct dentry *parent, u32 *value); struct dentry *parent, u32 *value);
struct dentry *debugfs_create_x64(const char *name, umode_t mode, struct dentry *debugfs_create_x64(const char *name, umode_t mode,
@ -275,12 +275,8 @@ static inline struct dentry *debugfs_create_x8(const char *name, umode_t mode,
return ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
} }
static inline struct dentry *debugfs_create_x16(const char *name, umode_t mode, static inline void debugfs_create_x16(const char *name, umode_t mode,
struct dentry *parent, struct dentry *parent, u16 *value) { }
u16 *value)
{
return ERR_PTR(-ENODEV);
}
static inline struct dentry *debugfs_create_x32(const char *name, umode_t mode, static inline struct dentry *debugfs_create_x32(const char *name, umode_t mode,
struct dentry *parent, struct dentry *parent,