p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[media] smiapp: Improve debug messages from frame layout reading 

Provide more debugging information on reading the frame layout.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Sakari Ailus 2016-09-07 09:53:42 -03:00 committed by Mauro Carvalho Chehab
parent 3fc34b7beb
commit e43665a9d7
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/media/i2c/smiapp/smiapp-core.c
View File

@ -100,12 +100,11 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor *sensor)
u32 pixels;
char *which;
char *what;
u32 reg;
if (fmt_model_type == SMIAPP_FRAME_FORMAT_MODEL_TYPE_2BYTE) {
rval = smiapp_read(
sensor,
SMIAPP_REG_U16_FRAME_FORMAT_DESCRIPTOR_2(i),
&desc);
reg = SMIAPP_REG_U16_FRAME_FORMAT_DESCRIPTOR_2(i);
rval = smiapp_read(sensor, reg, &desc);
if (rval)
return rval;
@ -116,10 +115,8 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor *sensor)
pixels = desc & SMIAPP_FRAME_FORMAT_DESC_2_PIXELS_MASK;
} else if (fmt_model_type
== SMIAPP_FRAME_FORMAT_MODEL_TYPE_4BYTE) {
rval = smiapp_read(
sensor,
SMIAPP_REG_U32_FRAME_FORMAT_DESCRIPTOR_4(i),
&desc);
reg = SMIAPP_REG_U32_FRAME_FORMAT_DESCRIPTOR_4(i);
rval = smiapp_read(sensor, reg, &desc);
if (rval)
return rval;
@ -158,12 +155,12 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor *sensor)
break;
default:
what = "invalid";
dev_dbg(&client->dev, "pixelcode %d\n", pixelcode);
break;
}
dev_dbg(&client->dev, "%s pixels: %d %s\n",
what, pixels, which);
dev_dbg(&client->dev,
"0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,
what, pixels, which, pixelcode);
if (i < ncol_desc) {
if (pixelcode ==