p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

thermal: imx: Use better parameter names than "val" 

The values passed to imx_init_calib() and imx_init_temp_grade() are
read from specific OCOTP values. Use their names (in lower case) as
parameter name instead of "val" to make the code easier to understand.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
This commit is contained in:
Uwe Kleine-König 2017-11-30 10:17:35 +01:00 committed by Eduardo Valentin
parent d790405d1b
commit e4bb2240d4
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/thermal/imx_thermal.c
View File

@ -347,13 +347,13 @@ static struct thermal_zone_device_ops imx_tz_ops = {
.set_trip_temp = imx_set_trip_temp, .set_trip_temp = imx_set_trip_temp,
}; };
static int imx_init_calib(struct platform_device *pdev, u32 val) static int imx_init_calib(struct platform_device *pdev, u32 ocotp_ana1)
{ {
struct imx_thermal_data *data = platform_get_drvdata(pdev); struct imx_thermal_data *data = platform_get_drvdata(pdev);
int t1, n1; int t1, n1;
u64 temp64; u64 temp64;
if (val == 0 || val == ~0) { if (ocotp_ana1 == 0 || ocotp_ana1 == ~0) {
dev_err(&pdev->dev, "invalid sensor calibration data\n"); dev_err(&pdev->dev, "invalid sensor calibration data\n");
return -EINVAL; return -EINVAL;
} }
@ -364,7 +364,7 @@ static int imx_init_calib(struct platform_device *pdev, u32 val)
* Use universal formula now and only need sensor value @ 25C * Use universal formula now and only need sensor value @ 25C
* slope = 0.4297157 - (0.0015976 * 25C fuse) * slope = 0.4297157 - (0.0015976 * 25C fuse)
*/ */
n1 = val >> 20; n1 = ocotp_ana1 >> 20;
t1 = 25; /* t1 always 25C */ t1 = 25; /* t1 always 25C */
/* /*
@ -392,12 +392,12 @@ static int imx_init_calib(struct platform_device *pdev, u32 val)
return 0; return 0;
} }
static void imx_init_temp_grade(struct platform_device *pdev, u32 val) static void imx_init_temp_grade(struct platform_device *pdev, u32 ocotp_mem0)
{ {
struct imx_thermal_data *data = platform_get_drvdata(pdev); struct imx_thermal_data *data = platform_get_drvdata(pdev);
/* The maximum die temp is specified by the Temperature Grade */ /* The maximum die temp is specified by the Temperature Grade */
switch ((val >> 6) & 0x3) { switch ((ocotp_mem0 >> 6) & 0x3) {
case 0: /* Commercial (0 to 95C) */ case 0: /* Commercial (0 to 95C) */
data->temp_grade = "Commercial"; data->temp_grade = "Commercial";
data->temp_max = 95000; data->temp_max = 95000;