p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

rxrpc: Fix returns of call completion helpers 

rxrpc_set_call_completion() returns bool, not int, so the ret variable
should match this.

rxrpc_call_completed() and __rxrpc_call_completed() should return the value
of rxrpc_set_call_completion().

Signed-off-by: David Howells <dhowells@redhat.com>
This commit is contained in:
David Howells 2016-09-07 16:34:12 +01:00
parent 8d94aa381d
commit e8d6bbb05a
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
net/rxrpc/ar-internal.h
View File

@ -608,7 +608,7 @@ static inline bool rxrpc_set_call_completion(struct rxrpc_call *call,
u32 abort_code, u32 abort_code,
int error) int error)
{ {
int ret; bool ret;
write_lock_bh(&call->state_lock); write_lock_bh(&call->state_lock);
ret = __rxrpc_set_call_completion(call, compl, abort_code, error); ret = __rxrpc_set_call_completion(call, compl, abort_code, error);
@ -619,16 +619,19 @@ static inline bool rxrpc_set_call_completion(struct rxrpc_call *call,
/* /*
* Record that a call successfully completed. * Record that a call successfully completed.
*/ */
static inline void __rxrpc_call_completed(struct rxrpc_call *call) static inline bool __rxrpc_call_completed(struct rxrpc_call *call)
{ {
__rxrpc_set_call_completion(call, RXRPC_CALL_SUCCEEDED, 0, 0); return __rxrpc_set_call_completion(call, RXRPC_CALL_SUCCEEDED, 0, 0);
} }
static inline void rxrpc_call_completed(struct rxrpc_call *call) static inline bool rxrpc_call_completed(struct rxrpc_call *call)
{ {
bool ret;
write_lock_bh(&call->state_lock); write_lock_bh(&call->state_lock);
__rxrpc_call_completed(call); ret = __rxrpc_call_completed(call);
write_unlock_bh(&call->state_lock); write_unlock_bh(&call->state_lock);
return ret;
} }
/* /*