p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ib_srpt: wait_for_completion_timeout does not return negative status 

This patch changes srpt_close_session() to properly use an unsigned long
for wait_for_completion_timeout()'s return value, and to update WARN_ON()
to only trigger for a zero return.

Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Nicholas Mc Guire 2015-01-16 12:20:17 +01:00 committed by Nicholas Bellinger
parent 5cdf5a87a2
commit ecc3f3edbf
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/infiniband/ulp/srpt/ib_srpt.c
View File

@ -3518,7 +3518,7 @@ static void srpt_close_session(struct se_session *se_sess)
DECLARE_COMPLETION_ONSTACK(release_done); DECLARE_COMPLETION_ONSTACK(release_done);
struct srpt_rdma_ch *ch; struct srpt_rdma_ch *ch;
struct srpt_device *sdev; struct srpt_device *sdev;
int res; unsigned long res;
ch = se_sess->fabric_sess_ptr; ch = se_sess->fabric_sess_ptr;
WARN_ON(ch->sess != se_sess); WARN_ON(ch->sess != se_sess);
@ -3533,7 +3533,7 @@ static void srpt_close_session(struct se_session *se_sess)
spin_unlock_irq(&sdev->spinlock); spin_unlock_irq(&sdev->spinlock);
res = wait_for_completion_timeout(&release_done, 60 * HZ); res = wait_for_completion_timeout(&release_done, 60 * HZ);
WARN_ON(res <= 0); WARN_ON(res == 0);
} }
/** /**