p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

clk: samsung: Suppress unbinding to prevent theoretical attacks 

Although unbinding a driver requires root privileges but it still might
be used theoretically in certain attacks (by triggering NULL pointer
exception or memory corruption if driver does not provide proper remove
callbacks or core does not handle it).

Samsung clock drivers are essential for system operation so their
removal is not expected. More over, the Exynos3250 ISP clock driver does
not implement remove() driver callback and it is not buildable as
modules.

Suppress the unbind interface for Exynos3250 ISP and S3C2410 DCLK clock
drivers.

Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
This commit is contained in:
Krzysztof Kozlowski 2016-05-17 09:26:14 +02:00 committed by Sylwester Nawrocki
parent 34cba90037
commit f4f4dd0c45
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/clk/samsung/clk-exynos3250.c
View File

@ -1087,6 +1087,7 @@ static const struct of_device_id exynos3250_cmu_isp_of_match[] __initconst = {
static struct platform_driver exynos3250_cmu_isp_driver __initdata = { static struct platform_driver exynos3250_cmu_isp_driver __initdata = {
.driver = { .driver = {
.name = "exynos3250-cmu-isp", .name = "exynos3250-cmu-isp",
.suppress_bind_attrs = true,
.of_match_table = exynos3250_cmu_isp_of_match, .of_match_table = exynos3250_cmu_isp_of_match,
}, },
}; };

5
drivers/clk/samsung/clk-s3c2410-dclk.c
View File

@ -428,8 +428,9 @@ MODULE_DEVICE_TABLE(platform, s3c24xx_dclk_driver_ids);
static struct platform_driver s3c24xx_dclk_driver = { static struct platform_driver s3c24xx_dclk_driver = {
.driver = { .driver = {
.name = "s3c24xx-dclk", .name = "s3c24xx-dclk",
.pm = &s3c24xx_dclk_pm_ops, .pm = &s3c24xx_dclk_pm_ops,
.suppress_bind_attrs = true,
}, },
.probe = s3c24xx_dclk_probe, .probe = s3c24xx_dclk_probe,
.remove = s3c24xx_dclk_remove, .remove = s3c24xx_dclk_remove,