p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eeprom: idt_89hpesx: remove unneeded csr_file variable 

The csr_file variable was only ever set, never read.  So remove it from
struct idt_89hpesx_dev as it is pointless to keep around.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2019-06-11 20:17:00 +02:00
parent 7603eab4a5
commit f506a547a9
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/misc/eeprom/idt_89hpesx.c
View File

@ -115,7 +115,6 @@ static struct dentry *csr_dbgdir;
* @client: i2c client used to perform IO operations * @client: i2c client used to perform IO operations
* *
* @ee_file: EEPROM read/write sysfs-file * @ee_file: EEPROM read/write sysfs-file
* @csr_file: CSR read/write debugfs-node
*/ */
struct idt_smb_seq; struct idt_smb_seq;
struct idt_89hpesx_dev { struct idt_89hpesx_dev {
@ -137,7 +136,6 @@ struct idt_89hpesx_dev {
struct bin_attribute *ee_file; struct bin_attribute *ee_file;
struct dentry *csr_dir; struct dentry *csr_dir;
struct dentry *csr_file;
}; };
/* /*
@ -1378,8 +1376,8 @@ static void idt_create_dbgfs_files(struct idt_89hpesx_dev *pdev)
pdev->csr_dir = debugfs_create_dir(fname, csr_dbgdir); pdev->csr_dir = debugfs_create_dir(fname, csr_dbgdir);
/* Create Debugfs file for CSR read/write operations */ /* Create Debugfs file for CSR read/write operations */
pdev->csr_file = debugfs_create_file(cli->name, 0600, debugfs_create_file(cli->name, 0600, pdev->csr_dir, pdev,
pdev->csr_dir, pdev, &csr_dbgfs_ops); &csr_dbgfs_ops);
} }
/* /*