p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pstore: Fix leaked pstore_record in pstore_get_backend_records() 

When the "if (record->size <= 0)" test is true in
pstore_get_backend_records() it's pretty clear that nobody holds a
reference to the allocated pstore_record, yet we don't free it.

Let's free it.

Fixes: 2a2b0acf76 ("pstore: Allocate records on heap instead of stack")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
This commit is contained in:
Douglas Anderson 2017-05-30 15:50:38 -07:00 committed by Kees Cook
parent 4a16d1cb24
commit f6525b96dd
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/pstore/platform.c
View File

@ -849,8 +849,10 @@ void pstore_get_backend_records(struct pstore_info *psi,
record->size = psi->read(record); record->size = psi->read(record);
/* No more records left in backend? */ /* No more records left in backend? */
if (record->size <= 0) if (record->size <= 0) {
kfree(record);
break; break;
}
decompress_record(record); decompress_record(record);
rc = pstore_mkfile(root, record); rc = pstore_mkfile(root, record);