p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

media: cec-gpio: use GPIOD_OUT_HIGH_OPEN_DRAIN 

This driver needs a pull up output GPIO, but devm_gpiod_get() is called
with GPIOD_IN. This apparently works fine for the RPi3 where the DT
correctly specifies a pull up GPIO, but on the i.MX6 it also needs to
be specified with devm_gpiod_get().

Reported-by: Henrik Mau <Henrik.Mau@linn.co.uk>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Hans Verkuil 2018-04-20 04:13:53 -04:00 committed by Mauro Carvalho Chehab
parent 8516529ee5
commit f6b6631478
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/platform/cec-gpio/cec-gpio.c
View File

@ -158,7 +158,7 @@ static int cec_gpio_probe(struct platform_device *pdev)
cec->dev = dev; cec->dev = dev;
cec->cec_gpio = devm_gpiod_get(dev, "cec", GPIOD_IN); cec->cec_gpio = devm_gpiod_get(dev, "cec", GPIOD_OUT_HIGH_OPEN_DRAIN);
if (IS_ERR(cec->cec_gpio)) if (IS_ERR(cec->cec_gpio))
return PTR_ERR(cec->cec_gpio); return PTR_ERR(cec->cec_gpio);
cec->cec_irq = gpiod_to_irq(cec->cec_gpio); cec->cec_irq = gpiod_to_irq(cec->cec_gpio);