p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

media: ov8856: Modify ov8856 register reading function to be simplified 

We use put_unaligned_be16() to be simplified for setting register address
in ov8856_read_reg() and use sizeof() to be better suited for bytes
copying.

Signed-off-by: Ben Kao <ben.kao@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Ben Kao 2019-01-15 07:36:07 -02:00 committed by Mauro Carvalho Chehab
parent 030f9f682e
commit fa65273401
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/i2c/ov8856.c
View File

@ -605,16 +605,17 @@ static int ov8856_read_reg(struct ov8856 *ov8856, u16 reg, u16 len, u32 *val)
{ {
struct i2c_client *client = v4l2_get_subdevdata(&ov8856->sd); struct i2c_client *client = v4l2_get_subdevdata(&ov8856->sd);
struct i2c_msg msgs[2]; struct i2c_msg msgs[2];
u8 addr_buf[2] = {reg >> 8, reg & 0xff}; u8 addr_buf[2];
u8 data_buf[4] = {0, }; u8 data_buf[4] = {0};
int ret; int ret;
if (len > 4) if (len > 4)
return -EINVAL; return -EINVAL;
put_unaligned_be16(reg, addr_buf);
msgs[0].addr = client->addr; msgs[0].addr = client->addr;
msgs[0].flags = 0; msgs[0].flags = 0;
msgs[0].len = ARRAY_SIZE(addr_buf); msgs[0].len = sizeof(addr_buf);
msgs[0].buf = addr_buf; msgs[0].buf = addr_buf;
msgs[1].addr = client->addr; msgs[1].addr = client->addr;
msgs[1].flags = I2C_M_RD; msgs[1].flags = I2C_M_RD;