p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sata_mv: Delete unnecessary checks before the function call "phy_power_off" 

The phy_power_off() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
Markus Elfring 2015-02-02 22:55:53 +01:00 committed by Tejun Heo
parent 214f1aff3f
commit fad0601643
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/ata/sata_mv.c
View File

@ -4185,8 +4185,7 @@ static int mv_platform_probe(struct platform_device *pdev)
clk_disable_unprepare(hpriv->port_clks[port]);
clk_put(hpriv->port_clks[port]);
}
if (hpriv->port_phys[port])
phy_power_off(hpriv->port_phys[port]);
phy_power_off(hpriv->port_phys[port]);
}
return rc;
@ -4216,8 +4215,7 @@ static int mv_platform_remove(struct platform_device *pdev)
clk_disable_unprepare(hpriv->port_clks[port]);
clk_put(hpriv->port_clks[port]);
}
if (hpriv->port_phys[port])
phy_power_off(hpriv->port_phys[port]);
phy_power_off(hpriv->port_phys[port]);
}
return 0;
}