p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

EDAC, altera: Simplify calculation of total memory 

Use of_address_to_resource() and resource_size() instead of manually
parsing the "reg" property from the "memory" node(s).

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Tested-by: Thor Thayer <thor.thayer@linux.intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20170606235500.22772-3-chris.packham@alliedtelesis.co.nz
Signed-off-by: Borislav Petkov <bp@suse.de>
This commit is contained in:
Chris Packham 2017-06-07 11:54:59 +12:00 committed by Borislav Petkov
parent 133e4455c9
commit ff0abed492
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/edac/altera_edac.c
View File

@ -214,24 +214,16 @@ static void altr_sdr_mc_create_debugfs_nodes(struct mem_ctl_info *mci)
static unsigned long get_total_mem(void) static unsigned long get_total_mem(void)
{ {
struct device_node *np = NULL; struct device_node *np = NULL;
const unsigned int *reg, *reg_end; struct resource res;
int len, sw, aw; int ret;
unsigned long start, size, total_mem = 0; unsigned long total_mem = 0;
for_each_node_by_type(np, "memory") { for_each_node_by_type(np, "memory") {
aw = of_n_addr_cells(np); ret = of_address_to_resource(np, 0, &res);
sw = of_n_size_cells(np); if (ret)
reg = (const unsigned int *)of_get_property(np, "reg", &len); continue;
reg_end = reg + (len / sizeof(u32));
total_mem = 0; total_mem += resource_size(&res);
do {
start = of_read_number(reg, aw);
reg += aw;
size = of_read_number(reg, sw);
reg += sw;
total_mem += size;
} while (reg < reg_end);
} }
edac_dbg(0, "total_mem 0x%lx\n", total_mem); edac_dbg(0, "total_mem 0x%lx\n", total_mem);
return total_mem; return total_mem;