Commit Graph

442574 Commits

Author SHA1 Message Date
Jes Sorensen edbfd672ca staging: rtl8723au: Call usb_write*() functions directly
This allows us to finally remove the ugly HAL interface for accessing
registers, and remove rtw_io.c

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:36 -07:00
Jes Sorensen 050abc4583 staging: rtl8723au: Call usb_read*() functions directly
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:35 -07:00
Jes Sorensen 1c1bc5f1dd staging: rtl8723au: Call usb_read_interrupt() directly instead of via HAL layer
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:35 -07:00
Jes Sorensen 633475cf5e staging: rtl8723au: Call usb_{read,write}_port() functions directly
Get rid of more HAL layer obfuscations

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:35 -07:00
Jes Sorensen 97ccc3a6be staging: rtl8723au: Clean up usb_{read,write}_port() usage
Get rid of silly HAL convolution for calling usb_{read,write}_port()
functions.

Benefit from fact we just have one input address for read_port, so no
point storing this and carrying it around.

Pick pipe in the local function instead of based on dst/src address.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:35 -07:00
Jes Sorensen 4810ce070e staging: rtl8723au: Use correct pipe type for USB interrupts
Use a correct pipe type when filling un interrupt urbs. This should
finally take care of the WARN() messages on the console when USB urbs
are submitted.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen af1853da17 staging: rtl8723au: Clean up mess of parenthesis abuse
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen 428891a3cb staging: rtl8723au: usb_ops_linux.h: Remove some unused #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen 2296fd2d92 staging: rtl8723au: Remove nasty wrappers used to hide wrong function types
Do not use #defines to hack around pre-history functions not matching
current APIs

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen a64ddc8d4e staging: rtl8723au: Remove unused USB bulk related macros and variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen 4631e5055e staging: rtl8723au: Don't wrap calls to usb_control_msg()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:34 -07:00
Jes Sorensen 596f85adaa staging: rtl8723au: Call usb_intf_{start,stop} directly
Rip out multiple layer of useless wrappers

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen c174eae6f7 staging: rtl8723au: Call rtl8723au_set_hw_type() directly
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen 43aeefd925 staging: rtl8723au: Remove unused usb_suspend_sema
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen 633dd914ca staging: rtl8723au: Move last utility function from osdep_service.c to os_intfs.c
No point carrying a dedicated file just for this small helper, so move
it to os_intfs.c and get rid of osdep_service.c

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen e6ac6eb2ae staging: rtl8723au: os_intfs.c: Various cosmetic cleanups
In addition skb->priorty is a u32, so make rtw_classify8021d return a
u32 to match.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:33 -07:00
Jes Sorensen eb269884cf staging: rtl8723au: os_dep/usb_ops_linux.c: More bad parenthesis cleanup
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen 7438ccb936 staging: rtl8723au: hal/usb_ops_linux.c: Various cleanups
Reduce excessive parenthesis usage, remove unnecessary null
initialization of variables, and some bad formatting.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen 9b00959fca staging: rtl8723au: odm_precomp.h: Remove unused #define TEST_FALG__
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen 18bd6df23d staging: rtl8723au: hal_com.c: Fix one case of returning status in an s32
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen 95d412d830 staging: rtl8723au: rtl8723a_cmd.c: Fix up bad return types
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:32 -07:00
Jes Sorensen a5681f99b4 staging: rtl8723au: rtl8723a_hal_init.c: Fix more messy return type abuse
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen c691ec3373 staging: rtl8723au: rtl8723a_phycfg.c: Use int for error return codes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen 5c195cc27b staging: rtl8723au: rtl8723au_xmit.c: Fixup messy return type usage
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen 24ed8e4575 staging: rtl8723au: rtl8723au_xmit_tasklet(): Remove unnecessary variable init
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen e04cd3f5ed staging: rtl8723au: usb_halinit.c: Another u8 error code case
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen 86c3e3f11e staging: rtl8723au: usb_intf.c: Fixup yet another round of u8 abuse for error type
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:31 -07:00
Jes Sorensen 9e2d06661a staging: rtl8723au: os_intfs.c: Fixup more u8/uint abuse for error return codes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen 16b9632da2 staging: rtl8732au: ioctl_cfg80211.c: Fix another case of u8 abuse for error return
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen 8fd873d93d staging: rtl8723au: rtw_xmit.c: Be consistent in using int for error return type
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen f6fe0a414b staging: rtl8723au: rtw_wlan_util.c: Fix up random mixing of bool vs int
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen 95ddd22553 staging: rtl8723au: rtw_sta_mgt.c: Clean up messy usage of return types
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:30 -07:00
Jes Sorensen 75f3f03956 staging: rtl8723au: rtw_security.c: Clean up mess of error return code types
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen 6963248033 staging: rtl8723au: decryptor() use int to store error codes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen d5789247bb staging: rtl8723au: Don't return true/false in unsigned int
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen f66e05d8fc staging: rtl8723au: rtw_mlme_ext.c: Use int to return error codes
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen 7e761c5a2a staging: rtl8723au: rtw_ioctl_set.c: Fix up messy error code handling
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:29 -07:00
Jes Sorensen 43eeb8ee53 staging: rtl8723au: Remove unused usb_read_mem/usb_write_mem stubs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:28 -07:00
Jes Sorensen ad899b1219 staging: rtl8723au: Clean up error codes in IO functions
This also fixes up another messy case assuming _FAIL == false and
true == _SUCCESS

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:28 -07:00
Jes Sorensen 828373f996 staging: rtl8723au: Remove unused rtw_is_wps_ie23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:28 -07:00
Jes Sorensen 44f3f16d8b staging: rtl8723au: Clean up error code mess in rtw_efuse.c
Use int to return error codes, and avoid mixing and matching
true/false with _FAIL/_SUCCESS at random.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:28 -07:00
Jes Sorensen 1ec8911b6d staging: rtl8723au: Make cmd and event handlers return int instead of u8
This is needed so we can eventually start passing around proper error
codes instead of the custom RTW ones.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:28 -07:00
Jes Sorensen 7271496bd1 staging: rtl8723au: Remove unused mp_custom_oid.h
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:28 -07:00
Jes Sorensen 60a2d48551 staging: rtl8723au: usb_vendor_req.h isn't used - remove it
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:27 -07:00
Jes Sorensen 25a931106f staging: rtl8723au: usb_osintf.h isn't used for anything - get rid of it
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:27 -07:00
Jes Sorensen 9385d861bd staging: rtl8723au: Get rid of rtl8723au_set_hal_ops() and get rid of hal_ops.h
Since rtl8723au_set_hal_ops() is just a kmalloc(), move it to
rtw_usb_if1_init() and fix the error handling to not leak memory.

This also allows us to get rid of hal_ops.h

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:27 -07:00
Jes Sorensen 02d50c22bd staging: rtl8723au: Remove sw led hal ops
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:27 -07:00
Jes Sorensen 10ce264649 staging: rtl8723au: Remove unused HAL interrupt function wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:27 -07:00
Jes Sorensen d9edcafbdc staging: rtl8723au: Remove unused hal_power_on() wrapper
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:27 -07:00
Jes Sorensen 39f1a8ebba staging: rtl8723au: Make direct calls to GetHalDefVar8192CUsb()
Remove another round of HAL wrapping, and remove unused
SetHalDefVar8192CUsb().

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-16 11:34:26 -07:00