Fam Zheng 0c8482ac92 [SCSI] virtio-scsi: Skip setting affinity on uninitialized vq ... virtscsi_init calls virtscsi_remove_vqs on err, even before initializing the vqs. The latter calls virtscsi_set_affinity, so let's check the pointer there before setting affinity on it. This fixes a panic when setting device's num_queues=2 on RHEL 6.5: qemu-system-x86_64 ... \ -device virtio-scsi-pci,id=scsi0,addr=0x13,...,num_queues=2 \ -drive file=/stor/vm/dummy.raw,id=drive-scsi-disk,... \ -device scsi-hd,drive=drive-scsi-disk,... [ 0.354734] scsi0 : Virtio SCSI HBA [ 0.379504] BUG: unable to handle kernel NULL pointer dereference at 0000000000000020 [ 0.380141] IP: [<ffffffff814741ef>] __virtscsi_set_affinity+0x4f/0x120 [ 0.380141] PGD 0 [ 0.380141] Oops: 0000 [#1] SMP [ 0.380141] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.14.0+ #5 [ 0.380141] Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2007 [ 0.380141] task: ffff88003c9f0000 ti: ffff88003c9f8000 task.ti: ffff88003c9f8000 [ 0.380141] RIP: 0010:[<ffffffff814741ef>] [<ffffffff814741ef>] __virtscsi_set_affinity+0x4f/0x120 [ 0.380141] RSP: 0000:ffff88003c9f9c08 EFLAGS: 00010256 [ 0.380141] RAX: 0000000000000000 RBX: ffff88003c3a9d40 RCX: 0000000000001070 [ 0.380141] RDX: 0000000000000002 RSI: 0000000000000000 RDI: 0000000000000000 [ 0.380141] RBP: ffff88003c9f9c28 R08: 00000000000136c0 R09: ffff88003c801c00 [ 0.380141] R10: ffffffff81475229 R11: 0000000000000008 R12: 0000000000000000 [ 0.380141] R13: ffffffff81cc7ca8 R14: ffff88003cac3d40 R15: ffff88003cac37a0 [ 0.380141] FS: 0000000000000000(0000) GS:ffff88003e400000(0000) knlGS:0000000000000000 [ 0.380141] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 0.380141] CR2: 0000000000000020 CR3: 0000000001c0e000 CR4: 00000000000006f0 [ 0.380141] Stack: [ 0.380141] ffff88003c3a9d40 0000000000000000 ffff88003cac3d80 ffff88003cac3d40 [ 0.380141] ffff88003c9f9c48 ffffffff814742e8 ffff88003c26d000 ffff88003c26d000 [ 0.380141] ffff88003c9f9c68 ffffffff81474321 ffff88003c26d000 ffff88003c3a9d40 [ 0.380141] Call Trace: [ 0.380141] [<ffffffff814742e8>] virtscsi_set_affinity+0x28/0x40 [ 0.380141] [<ffffffff81474321>] virtscsi_remove_vqs+0x21/0x50 [ 0.380141] [<ffffffff81475231>] virtscsi_init+0x91/0x240 [ 0.380141] [<ffffffff81365290>] ? vp_get+0x50/0x70 [ 0.380141] [<ffffffff81475544>] virtscsi_probe+0xf4/0x280 [ 0.380141] [<ffffffff81363ea5>] virtio_dev_probe+0xe5/0x140 [ 0.380141] [<ffffffff8144c669>] driver_probe_device+0x89/0x230 [ 0.380141] [<ffffffff8144c8ab>] __driver_attach+0x9b/0xa0 [ 0.380141] [<ffffffff8144c810>] ? driver_probe_device+0x230/0x230 [ 0.380141] [<ffffffff8144c810>] ? driver_probe_device+0x230/0x230 [ 0.380141] [<ffffffff8144ac1c>] bus_for_each_dev+0x8c/0xb0 [ 0.380141] [<ffffffff8144c499>] driver_attach+0x19/0x20 [ 0.380141] [<ffffffff8144bf28>] bus_add_driver+0x198/0x220 [ 0.380141] [<ffffffff8144ce9f>] driver_register+0x5f/0xf0 [ 0.380141] [<ffffffff81d27c91>] ? spi_transport_init+0x79/0x79 [ 0.380141] [<ffffffff8136403b>] register_virtio_driver+0x1b/0x30 [ 0.380141] [<ffffffff81d27d19>] init+0x88/0xd6 [ 0.380141] [<ffffffff81d27c18>] ? scsi_init_procfs+0x5b/0x5b [ 0.380141] [<ffffffff81ce88a7>] do_one_initcall+0x7f/0x10a [ 0.380141] [<ffffffff81ce8aa7>] kernel_init_freeable+0x14a/0x1de [ 0.380141] [<ffffffff81ce8b3b>] ? kernel_init_freeable+0x1de/0x1de [ 0.380141] [<ffffffff817dec20>] ? rest_init+0x80/0x80 [ 0.380141] [<ffffffff817dec29>] kernel_init+0x9/0xf0 [ 0.380141] [<ffffffff817e68fc>] ret_from_fork+0x7c/0xb0 [ 0.380141] [<ffffffff817dec20>] ? rest_init+0x80/0x80 [ 0.380141] RIP [<ffffffff814741ef>] __virtscsi_set_affinity+0x4f/0x120 [ 0.380141] RSP <ffff88003c9f9c08> [ 0.380141] CR2: 0000000000000020 [ 0.380141] ---[ end trace 8074b70c3d5e1d73 ]--- [ 0.475018] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009 [ 0.475018] [ 0.475068] Kernel Offset: 0x0 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffff9fffffff) [ 0.475068] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009 [jejb: checkpatch fixes] Signed-off-by: Fam Zheng <famz@redhat.com> Acked-by: Paolo Bonzini <pbonzini@redhat.com> Cc: stable@vger.kernel.org Signed-off-by: James Bottomley <JBottomley@Parallels.com>		2014-04-28 16:16:08 -07:00
..
accessibility	…
acpi	Merge branches 'pnp' and 'acpi-hotplug'	2014-04-26 00:40:25 +02:00
amba	ARM: SoC: driver changes	2014-04-05 15:37:40 -07:00
ata	Merge branch 'for-3.15-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata	2014-04-24 09:57:02 -07:00
atm	…
auxdisplay	…
base	drivers/base/dd.c incorrect pr_debug() parameters	2014-04-16 19:34:46 -07:00
bcma	bcma: gpio: register 32 GPIOs on BCM5357	2014-03-27 14:20:04 -04:00
block	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2014-04-12 14:49:50 -07:00
bluetooth	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-04-02 20:53:45 -07:00
bus	ARM: SoC: driver changes	2014-04-05 15:37:40 -07:00
cdrom	…
char	TTY/Serial driver fixes for 3.15-rc2	2014-04-18 16:57:53 -07:00
clk	ARM Versatile Express fixes for 3.15	2014-04-24 23:46:58 +02:00
clocksource	clocksource: Exynos_mct: Register clock event after request_irq()	2014-04-17 23:36:28 +02:00
connector	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-04-02 20:53:45 -07:00
cpufreq	cpufreq: highbank: fix ARM_HIGHBANK_CPUFREQ dependency warning	2014-04-22 00:09:09 +02:00
cpuidle	Merge branch 'pm-cpuidle'	2014-04-08 13:27:40 +02:00
crypto	Merge git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2014-04-03 09:28:16 -07:00
dca	…
devfreq	…
dio	…
dma	dma: fix eDMA driver as a subsys_initcall	2014-04-16 12:03:47 +05:30
edac	Merge branch 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media	2014-04-04 09:50:07 -07:00
eisa	…
extcon	…
firewire	…
firmware	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-04-11 11:58:33 -07:00
fmc	…
gpio	A few fixes for the GPIO tree:	2014-04-22 09:28:02 -07:00
gpu	drm/radeon: don't allow runpm=1 on systems with out ATPX	2014-04-22 16:51:21 +02:00
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid	2014-04-18 10:31:34 -07:00
hsi	…
hv	Drivers: hv: vmbus: Negotiate version 3.0 when running on ws2012r2 hosts	2014-04-16 14:14:07 -07:00
hwmon	hwmon: (ltc2945) Don't crash the kernel unnecessarily	2014-04-24 06:09:43 -07:00
hwspinlock	…
i2c	Merge branch 'i2c/for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux	2014-04-09 08:45:40 -07:00
ide	…
idle	intel_idle: fix IVT idle state table setting	2014-04-21 23:36:07 +02:00
iio	First found of IIO fixes for the 3.15 cycle.	2014-04-22 21:29:20 -07:00
infiniband	InfiniBand/RDMA updates for 3.15-rc2:	2014-04-18 13:49:42 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2014-04-23 07:48:03 -07:00
iommu	Merge git://git.infradead.org/iommu-2.6 into iommu/fixes	2014-04-16 16:09:40 +02:00
ipack	…
irqchip	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-04-27 11:21:03 -07:00
isdn	isdn: icn: buffer overflow in icn_command()	2014-04-16 15:24:15 -04:00
leds	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds	2014-04-10 09:06:10 -07:00
lguest	drivers/lguest/page_tables.c: rename do_set_pte()	2014-04-07 16:35:52 -07:00
macintosh	…
mailbox	…
mcb	drivers: mcb: fix memory leak in chameleon_parse_cells() error path	2014-04-16 12:28:47 -07:00
md	One BUG fix for md for recent commit	2014-04-17 10:51:01 -07:00
media	platform: Fix timberdale dependencies	2014-04-16 11:57:27 +05:30
memory	…
memstick	…
message	PCI changes for the v3.15 merge window:	2014-04-01 15:14:04 -07:00
mfd	MMC highlights for 3.15:	2014-04-09 08:39:39 -07:00
misc	misc: Grammar s/addition/additional/	2014-04-16 12:28:47 -07:00
mmc	MMC highlights for 3.15:	2014-04-09 08:39:39 -07:00
mtd	Shiraz has moved	2014-04-18 16:40:08 -07:00
net	Merge branch 'for-davem' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless	2014-04-18 18:29:44 -04:00
nfc	…
ntb	ntb: Use pci_enable_msix_range() instead of pci_enable_msix()	2014-04-07 10:59:20 -07:00
nubus	…
of	of: Clean up of_update_property	2014-04-15 15:21:22 -05:00
oprofile	…
parisc	…
parport	…
pci	PCI: tegra: Use new OF interrupt mapping when possible	2014-04-16 10:24:32 -06:00
pcmcia	PCI changes for the v3.15 merge window:	2014-04-01 15:14:04 -07:00
phy	phy: fix kernel oops in phy_lookup()	2014-04-24 12:53:38 -07:00
pinctrl	pinctrl: Rename Broadcom Capri pinctrl driver	2014-04-14 09:39:33 +02:00
platform	alienware-wmi: cover some scenarios where memory allocations would fail	2014-04-10 12:11:56 -04:00
pnp	PNP: Work around BIOS defects in Intel MCH area reporting	2014-04-24 02:39:40 +02:00
power	power/reset: vexpress: Fix restart/power off operation	2014-04-24 17:20:50 +01:00
powercap	CPU hotplug notifiers registration fixes for 3.15-rc1	2014-04-07 14:55:46 -07:00
pps	…
ps3	…
ptp	net: ptp: move PTP classifier in its own file	2014-04-01 16:43:18 -04:00
pwm	Shiraz has moved	2014-04-18 16:40:08 -07:00
rapidio	rapidio: rework device hierarchy and introduce mport class of devices	2014-04-07 16:36:07 -07:00
regulator	regulator: pbias: Convert to use regmap helper functions	2014-04-14 22:16:25 +01:00
remoteproc	…
reset	…
rpmsg	…
rtc	ARM: SoC: driver changes	2014-04-05 15:37:40 -07:00
s390	s390/sclp_cmd: replace PTR_RET with PTR_ERR_OR_ZERO	2014-04-11 13:53:42 +02:00
sbus	…
scsi	[SCSI] virtio-scsi: Skip setting affinity on uninitialized vq	2014-04-28 16:16:08 -07:00
sfi	…
sh	ARM: SoC: sh driver changes	2014-04-05 15:38:41 -07:00
sn	…
spi	Merge remote-tracking branches 'spi/fix/atmel', 'spi/fix/bfin5xx', 'spi/fix/hspi' and 'spi/fix/sirf' into spi-linus	2014-04-23 13:50:18 +01:00
spmi	…
ssb	…
staging	staging: comedi: usbdux: bug fix for accessing 'ao_chanlist' in private data	2014-04-23 16:20:15 -07:00
target	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-04-12 17:31:22 -07:00
tc	…
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2014-04-10 09:15:46 -07:00
tty	serial_core: fix uart PORT_UNKNOWN handling	2014-04-24 15:38:22 -07:00
uio	…
usb	usb: option: add and update a number of CMOTech devices	2014-04-25 11:35:04 -07:00
uwb	uwb: don't call spin_unlock_irq in a USB completion handler	2014-04-24 12:45:40 -07:00
vfio	VFIO updates for v3.15 include:	2014-04-03 14:05:02 -07:00
vhost	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2014-04-12 16:51:08 -07:00
video	video: Kconfig: move drm and fb into separate menus	2014-04-17 08:10:20 +03:00
virt	…
virtio	…
vlynq	…
vme	vme_tsi148: Utilize to_pci_dev() macro	2014-04-16 14:08:37 -07:00
w1	w1: avoid recursive device_add	2014-04-16 14:07:51 -07:00
watchdog	CPU hotplug notifiers registration fixes for 3.15-rc1	2014-04-07 14:55:46 -07:00
xen	Xen regression and bug fixes for 3.15-rc1.	2014-04-17 10:54:07 -07:00
zorro	…
Kconfig	…
Makefile	video: move fbdev to drivers/video/fbdev	2014-04-17 08:10:19 +03:00