linux_old1/drivers/hid/usbhid
Anssi Hannula f129ea6d1e HID: fix a lockup regression when using force feedback on a PID device
Commit 8006479c9b introduced a spinlock in
input_dev->event_lock, which is locked when handling input events.
However, the hid-pidff driver sleeps when handling events as it waits for
reports being sent to the device before changing the report contents
again.
This causes a system lockup when trying to use force feedback with a PID
device, a regression introduced in 2.6.24 and 2.6.23.15.

Fix it by extracting the raw report data from struct hid_report
immediately when hid_submit_report() is called, therefore allowing
drivers to change the contents of struct hid_report immediately without
affecting the already-queued transfer.

In hid-pidff, re-add the removed usbhid_wait_io() to
pidff_erase_effect() instead, to prevent a full report queue from causing
the submission to fail, thus not freeing up device memory.
pidff_erase_effect() is not called while dev->event_lock is held.

Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
2008-10-14 23:51:02 +02:00
..
Kconfig HID: remove hid-ff 2008-10-14 23:51:01 +02:00
Makefile HID: remove hid-ff 2008-10-14 23:51:01 +02:00
hid-core.c HID: fix a lockup regression when using force feedback on a PID device 2008-10-14 23:51:02 +02:00
hid-pidff.c HID: fix a lockup regression when using force feedback on a PID device 2008-10-14 23:51:02 +02:00
hid-quirks.c HID: move pantherlord FF processing 2008-10-14 23:51:00 +02:00
hiddev.c HID: move connect quirks 2008-10-14 23:50:56 +02:00
usbhid.h HID: fix a lockup regression when using force feedback on a PID device 2008-10-14 23:51:02 +02:00
usbkbd.c HID: remove quirk lookup from usbkbd/usbmouse 2008-07-23 15:25:22 +02:00
usbmouse.c HID: move apple quirks 2008-10-14 23:50:49 +02:00