Reyad Attiyat 11bdc44093 mwifiex: usb: Fix double add error when submitting rx urb ... There is an error that can occur where the driver adds the same URB to USB submission list twice. This happens since mwifiex_usb_submit_rem_rx can submit packets at same time as an rx urb complete callback. This causes list corruption and is fixed by not setting the skb to NULL when submitting an rx packet. [ 84.461242] WARNING: CPU: 1 PID: 748 at lib/list_debug.c:36 __list_add+0xcb/0xd0() [ 84.461245] list_add double add: new=ffff8800c92b0c50, prev=ffff8800c92b0c50, next=ffff8800ced6c430. [ 84.461247] Modules linked in: rfcomm fuse cmac nf_conntrack_netbios_ns nf_conntrack_broadcast ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack bnep iptable_mangle iptable_security iptable_raw btusb btintel bluetooth mwifiex_usb mwifiex x86_pkg_temp_thermal cfg80211 coretemp r8712u(C) kvm_intel kvm hid_sensor_als hid_sensor_incl_3d hid_sensor_rotation hid_sensor_magn_3d hid_sensor_accel_3d hid_sensor_gyro_3d hid_sensor_trigger hid_sensor_iio_common industrialio_triggered_buffer kfifo_buf rfkill iTCO_wdt industrialio iTCO_vendor_support [ 84.461316] crc32_pclmul crc32c_intel ghash_clmulni_intel microcode snd_hda_codec_realtek vfat snd_hda_codec_generic fat snd_hda_codec_hdmi snd_hda_intel snd_hda_controller uvcvideo snd_hda_codec videobuf2_vmalloc videobuf2_memops snd_hwdep videobuf2_core snd_hda_core joydev v4l2_common videodev hid_sensor_hub snd_seq hid_multitouch media snd_seq_device snd_pcm snd_timer mei_me snd i2c_i801 lpc_ich mei soundcore tpm_infineon tpm_tis tpm i2c_hid i2c_designware_platform i2c_designware_core nfsd auth_rpcgss nfs_acl lockd grace sunrpc sch_fq_codel i915 i2c_algo_bit drm_kms_helper drm xhci_pci xhci_hcd ehci_pci sd_mod ehci_hcd video [ 84.461383] CPU: 1 PID: 748 Comm: kworker/u9:0 Tainted: G C 4.1.0-rc5+ #163 [ 84.461386] Hardware name: Microsoft Corporation Surface Pro 2/Surface Pro 2, BIOS 2.05.0250 04/10/2015 [ 84.461396] Workqueue: MWIFIEX_RX_WORK_QUEUE mwifiex_rx_work_queue [mwifiex] [ 84.461399] ffffffff81a8150e ffff8801174cf8e8 ffffffff817df830 0000000000000000 [ 84.461405] ffff8801174cf938 ffff8801174cf928 ffffffff810a54ba ffff8800c86bd750 [ 84.461410] ffff8800c92b0c50 ffff8800c92b0c50 ffff8800ced6c430 ffff88010c057178 [ 84.461416] Call Trace: [ 84.461421] [<ffffffff817df830>] dump_stack+0x4f/0x7b [ 84.461428] [<ffffffff810a54ba>] warn_slowpath_common+0x8a/0xc0 [ 84.461432] [<ffffffff810a5536>] warn_slowpath_fmt+0x46/0x50 [ 84.461436] [<ffffffff814109fb>] __list_add+0xcb/0xd0 [ 84.461442] [<ffffffff815c551a>] ? usb_hcd_link_urb_to_ep+0x2a/0xa0 [ 84.461446] [<ffffffff815c5570>] usb_hcd_link_urb_to_ep+0x80/0xa0 [ 84.461459] [<ffffffffa004318a>] prepare_transfer+0xaa/0x130 [xhci_hcd] [ 84.461470] [<ffffffffa0044cf7>] xhci_queue_bulk_tx+0xb7/0x7a0 [xhci_hcd] [ 84.461480] [<ffffffffa003b67f>] ? xhci_urb_enqueue+0x50f/0x660 [xhci_hcd] [ 84.461489] [<ffffffffa003b67f>] ? xhci_urb_enqueue+0x50f/0x660 [xhci_hcd] [ 84.461498] [<ffffffffa003b735>] xhci_urb_enqueue+0x5c5/0x660 [xhci_hcd] [ 84.461503] [<ffffffff815c7ad3>] usb_hcd_submit_urb+0x93/0xa70 [ 84.461507] [<ffffffff8168dde8>] ? __alloc_skb+0x78/0x1f0 [ 84.461511] [<ffffffff8168d301>] ? __kmalloc_reserve.isra.26+0x31/0x90 [ 84.461515] [<ffffffff8168ddbc>] ? __alloc_skb+0x4c/0x1f0 [ 84.461519] [<ffffffff8168ddfc>] ? __alloc_skb+0x8c/0x1f0 [ 84.461523] [<ffffffff8168badd>] ? skb_dequeue+0x5d/0x80 [ 84.461527] [<ffffffff815c987e>] usb_submit_urb+0x42e/0x5f0 [ 84.461531] [<ffffffff816931d9>] ? __alloc_rx_skb+0x39/0x100 [ 84.461536] [<ffffffffa05aa372>] mwifiex_usb_submit_rx_urb+0xb2/0x170 [mwifiex_usb] [ 84.461542] [<ffffffffa05aa5f5>] mwifiex_usb_submit_rem_rx_urbs+0x45/0x50 [mwifiex_usb] [ 84.461550] [<ffffffffa07094be>] mwifiex_rx_work_queue+0x10e/0x140 [mwifiex] [ 84.461556] [<ffffffff810c4429>] process_one_work+0x229/0x890 [ 84.461559] [<ffffffff810c438c>] ? process_one_work+0x18c/0x890 [ 84.461565] [<ffffffff810c4ae3>] worker_thread+0x53/0x470 [ 84.461569] [<ffffffff810c4a90>] ? process_one_work+0x890/0x890 [ 84.461572] [<ffffffff810cb162>] kthread+0xf2/0x110 [ 84.461577] [<ffffffff811031ad>] ? trace_hardirqs_on+0xd/0x10 [ 84.461581] [<ffffffff810cb070>] ? kthread_create_on_node+0x230/0x230 [ 84.461586] [<ffffffff817e9662>] ret_from_fork+0x42/0x70 [ 84.461590] [<ffffffff810cb070>] ? kthread_create_on_node+0x230/0x230 [ 84.461593] ---[ end trace 65103af5e6fb3444 ]--- Signed-off-by: Reyad Attiyat <reyad.attiyat@gmail.com> Acked-by: Amitkumar Karwar <akarwar@marvell.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>		2015-07-21 16:50:40 +03:00
..
accessibility	…
acpi	Power management and ACPI fixes for v4.2-rc1	2015-07-01 14:17:44 -07:00
amba	…
android	…
ata	ARM: SoC cleanups for v4.2	2015-06-26 11:08:27 -07:00
atm	…
auxdisplay	…
base	Merge branch 'akpm' (patches from Andrew)	2015-07-01 17:47:51 -07:00
bcma	…
block	xen: features and cleanups for 4.2-rc0	2015-07-01 11:53:46 -07:00
bluetooth	Bluetooth: ath3k: Add support of 04ca:300d AR3012 device	2015-06-18 21:00:06 +03:00
bus	ARM: SoC: driver updates for v4.2	2015-06-26 11:54:29 -07:00
cdrom	…
char	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
clk	Replace module_platform_driver with builtin_platform driver in non modules.	2015-07-02 10:42:13 -07:00
clocksource	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:44:18 -07:00
connector	…
cpufreq	Replace module_platform_driver with builtin_platform driver in non modules.	2015-07-02 10:42:13 -07:00
cpuidle	Replace module_platform_driver with builtin_platform driver in non modules.	2015-07-02 10:42:13 -07:00
crypto	Merge branch 'akpm' (patches from Andrew)	2015-07-01 17:47:51 -07:00
dca	…
devfreq	…
dio	…
dma	Merge branch 'akpm' (patches from Andrew)	2015-07-01 17:47:51 -07:00
dma-buf	…
edac	Driver core patches for 4.2-rc1	2015-06-26 15:07:37 -07:00
eisa	…
extcon	…
firewire	…
firmware	Devicetree changes for v4.2	2015-07-01 19:40:18 -07:00
fmc	…
gpio	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:19:35 -07:00
gpu	Fix up implicit <module.h> users that will break later.	2015-07-02 10:25:22 -07:00
hid	Merge branches 'for-4.2/i2c-hid', 'for-4.2/lenovo', 'for-4.2/plantronics', 'for-4.2/rmi', 'for-4.2/sensor-hub', 'for-4.2/sjoy', 'for-4.2/sony' and 'for-4.2/wacom' into for-linus	2015-06-22 16:23:43 +02:00
hsi	Fix up implicit <module.h> users that will break later.	2015-07-02 10:25:22 -07:00
hv	…
hwmon	Char/Misc driver patches for 4.2-rc1	2015-06-26 14:51:15 -07:00
hwspinlock	…
hwtracing/coresight	…
i2c	Char/Misc driver patches for 4.2-rc1	2015-06-26 14:51:15 -07:00
ide	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
idle	…
iio	…
infiniband	Merge branch 'akpm' (patches from Andrew)	2015-07-01 17:47:51 -07:00
input	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
iommu	IOMMU Fixes for Linux v4.2-rc0	2015-07-01 14:44:22 -07:00
ipack	…
irqchip	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-06-27 12:44:34 -07:00
isdn	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2015-06-24 16:49:49 -07:00
leds	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds	2015-07-01 19:09:11 -07:00
lguest	Merge branch 'x86-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-06-22 17:59:09 -07:00
macintosh	…
mailbox	Replace module_init with appropriate alternate initcall in non modules.	2015-07-02 10:36:29 -07:00
mcb	…
md	MAINTAINERS: BCACHE: Kent Overstreet has changed email address	2015-06-30 19:45:01 -07:00
media	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds	2015-07-01 19:09:11 -07:00
memory	ARM: SoC: driver updates for v4.2	2015-06-26 11:54:29 -07:00
memstick	memstick: remove deprecated use of pci api	2015-06-30 19:44:57 -07:00
message	…
mfd	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:19:35 -07:00
misc	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
mmc	Merge branch 'for-4.2/sg' of git://git.kernel.dk/linux-block	2015-06-25 15:22:36 -07:00
mtd	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
net	mwifiex: usb: Fix double add error when submitting rx urb	2015-07-21 16:50:40 +03:00
nfc	Char/Misc driver patches for 4.2-rc1	2015-06-26 14:51:15 -07:00
ntb	PCI changes for the v4.2 merge window:	2015-06-23 13:41:24 -07:00
nubus	…
nvdimm	arch, x86: pmem api for ensuring durability of persistent memory updates	2015-06-26 11:23:38 -04:00
of	Devicetree changes for v4.2	2015-07-01 19:40:18 -07:00
oprofile	…
parisc	…
parport	…
pci	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:19:35 -07:00
pcmcia	Fix up implicit <module.h> users that will break later.	2015-07-02 10:25:22 -07:00
phy	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-06-27 12:44:34 -07:00
pinctrl	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:19:35 -07:00
platform	Replace module_platform_driver with builtin_platform driver in non modules.	2015-07-02 10:42:13 -07:00
pnp	Merge branches 'pnp' and 'pm-tools'	2015-06-19 01:18:43 +02:00
power	Replace module_platform_driver with builtin_platform driver in non modules.	2015-07-02 10:42:13 -07:00
powercap	…
pps	…
ps3	…
ptp	…
pwm	pwm: Changes for v4.2-rc1	2015-06-23 13:32:38 -07:00
rapidio	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2015-06-23 14:08:54 -07:00
ras	…
regulator	Fix up implicit <module.h> users that will break later.	2015-07-02 10:25:22 -07:00
remoteproc	…
reset	…
rpmsg	…
rtc	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2015-06-27 12:44:34 -07:00
s390	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux	2015-06-30 21:44:14 -07:00
sbus	…
scsi	libcxgbi: use kvfree() in cxgbi_free_big_mem()	2015-06-30 19:45:00 -07:00
sfi	…
sh	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-01 15:19:35 -07:00
sn	…
soc	Replace module_platform_driver with builtin_platform driver in non modules.	2015-07-02 10:42:13 -07:00
spi	Merge remote-tracking branches 'spi/topic/sirf', 'spi/topic/spidev' and 'spi/topic/zynq' into spi-next	2015-06-18 00:19:56 +01:00
spmi	…
ssb	…
staging	Staging driver patches for 4.2-rc1	2015-06-26 15:46:08 -07:00
target	target: use kvfree() in session alloc and free	2015-06-30 19:45:00 -07:00
tc	…
thermal	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
thunderbolt	…
tty	Replace module_init with equivalent device_initcall in non modules.	2015-07-02 10:30:48 -07:00
uio	…
usb	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
uwb	…
vfio	VFIO updates for v4.2	2015-06-28 12:32:13 -07:00
vhost	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2015-06-24 16:49:49 -07:00
video	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
virt	…
virtio	Minor merge needed, due to function move.	2015-07-01 10:49:25 -07:00
vlynq	…
vme	…
w1	…
watchdog	Merge git://www.linux-watchdog.org/linux-watchdog	2015-07-01 19:33:16 -07:00
xen	xen: features and cleanups for 4.2-rc0	2015-07-01 11:53:46 -07:00
zorro	…
Kconfig	libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support	2015-06-24 21:24:10 -04:00
Makefile	The libnvdimm sub-system introduces, in addition to the libnvdimm-core,	2015-06-29 10:34:42 -07:00