Chris Wilson 1a72d65d62 drm: Remove count_lock for calling lastclose() after 58474713 (v2) ... When removing of the BKL the locking around lastclose() was rearranged and resulted in the holding of the open_count spinlock over the call into drm_lastclose(). The drivers were not ready for this path to be atomic - it may indeed involve long waits to release old objects and cleanup the GPU - and so we ended up scheduling whilst atomic. [ 54.625598] BUG: scheduling while atomic: X/3546/0x00000002 [ 54.625600] Modules linked in: sco bridge stp llc input_polldev rfcomm bnep l2cap crc16 sch_sfq ipv6 md_mod acpi_cpufreq mperf cryptd aes_x86_64 aes_generic xts gf128mul dm_crypt dm_mod btusb bluetooth usbhid hid zaurus cdc_ether usbnet mii cdc_wdm cdc_acm uvcvideo videodev v4l1_compat v4l2_compat_ioctl32 snd_hda_codec_conexant arc4 pcmcia ecb snd_hda_intel joydev sdhci_pci sdhci snd_hda_codec tpm_tis firewire_ohci mmc_core e1000e uhci_hcd thinkpad_acpi nvram yenta_socket pcmcia_rsrc pcmcia_core tpm wmi sr_mod firewire_core iwlagn ehci_hcd snd_hwdep snd_pcm usbcore tpm_bios thermal led_class snd_timer iwlcore snd soundcore ac snd_page_alloc pcspkr psmouse serio_raw battery sg mac80211 evdev cfg80211 i2c_i801 iTCO_wdt iTCO_vendor_support cdrom processor crc_itu_t rfkill xfs exportfs sd_mod crc_t10dif ahci libahci libata scsi_mod [last unloaded: scsi_wait_scan] [ 54.625663] Pid: 3546, comm: X Not tainted 2.6.35-04771-g1787985 #301 [ 54.625665] Call Trace: [ 54.625671] [<ffffffff8102d599>] __schedule_bug+0x57/0x5c [ 54.625675] [<ffffffff81384141>] schedule+0xe5/0x832 [ 54.625679] [<ffffffff81163e77>] ? put_dec+0x20/0x3c [ 54.625682] [<ffffffff81384dd4>] schedule_timeout+0x275/0x29f [ 54.625686] [<ffffffff810455e1>] ? process_timeout+0x0/0xb [ 54.625688] [<ffffffff81384e17>] schedule_timeout_uninterruptible+0x19/0x1b [ 54.625691] [<ffffffff81045893>] msleep+0x16/0x1d [ 54.625695] [<ffffffff812a2e53>] i9xx_crtc_dpms+0x273/0x2ae [ 54.625698] [<ffffffff812a18be>] intel_crtc_dpms+0x28/0xe7 [ 54.625702] [<ffffffff811ec0fa>] drm_helper_disable_unused_functions+0xf0/0x118 [ 54.625705] [<ffffffff811ecde3>] drm_crtc_helper_set_config+0x644/0x7c8 [ 54.625708] [<ffffffff811f12dd>] ? drm_copy_field+0x40/0x50 [ 54.625711] [<ffffffff811ebca2>] drm_fb_helper_force_kernel_mode+0x3e/0x85 [ 54.625713] [<ffffffff811ebcf2>] drm_fb_helper_restore+0x9/0x24 [ 54.625717] [<ffffffff81290a41>] i915_driver_lastclose+0x2b/0x5c [ 54.625720] [<ffffffff811f14a7>] drm_lastclose+0x44/0x2ad [ 54.625722] [<ffffffff811f1ed2>] drm_release+0x5c6/0x609 [ 54.625726] [<ffffffff810d1275>] fput+0x109/0x1c7 [ 54.625728] [<ffffffff810ce5e4>] filp_close+0x61/0x6b [ 54.625731] [<ffffffff810ce680>] sys_close+0x92/0xd4 [ 54.625734] [<ffffffff81002a2b>] system_call_fastpath+0x16/0x1b v2: The spinlock is actually superfluous as access to open_count is entirely serialised by drm_global_mutex and so can be dropped. The count_lock spinlock instead appears to be used to protect access to dev->buf_alloc and dev->buf_use. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Dave Airlie <airlied@redhat.com>		2010-08-12 09:22:19 +10:00
..
accessibility	…
acpi	Merge branch 'bugzilla-16396' into release	2010-07-24 23:26:22 -04:00
amba	…
ata	ata_generic: implement ATA_GEN_* flags and force enable DMA on MBP 7,1	2010-07-01 15:34:48 -04:00
atm	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
auxdisplay	auxdisplay: section cleanup in cfag12864bfb driver	2010-05-25 08:07:09 -07:00
base	Driver-core: Always create class directories for classses that support namespaces.	2010-07-26 08:05:31 -07:00
block	cciss: set SCSI max cmd len to 16, as default is wrong	2010-06-15 08:12:34 +02:00
bluetooth	drivers: bluetooth: bluecard_cs.c: Fixed include error, changed to linux/io.h	2010-07-01 21:28:14 -07:00
cdrom	…
char	agp: intel-agp: do not use PCI resources before pci_enable_device()	2010-08-05 12:28:25 +10:00
clocksource	Andres has moved	2010-07-20 16:25:41 -07:00
connector	…
cpufreq	[CPUFREQ] fix memory leak in cpufreq_add_dev	2010-07-26 15:25:33 -04:00
cpuidle	sched: Cure nr_iowait_cpu() users	2010-07-01 09:39:48 +02:00
crypto	crypto: talitos - fix bug in sg_copy_end_to_buffer	2010-07-19 14:11:24 +08:00
dca	…
dio	…
dma	of/dma: fix build breakage in ppc4xx adma driver	2010-07-02 15:46:17 -06:00
edac	edac: mpc85xx: fix coldplug/hotplug module autoloading	2010-07-27 14:32:06 -07:00
eisa	…
firewire	firewire: core: check for 1394a compliant IRM, fix inaccessibility of Sony camcorder	2010-06-02 19:48:13 +02:00
firmware	sysfs: add struct file* to bin_attr callbacks	2010-05-21 09:37:31 -07:00
gpio	gpio: fix spurious printk when freeing a gpio	2010-07-27 14:32:07 -07:00
gpu	drm: Remove count_lock for calling lastclose() after 58474713 (v2)	2010-08-12 09:22:19 +10:00
hid	HID: Send Report ID when numbered reports are sent over the control endpoint.	2010-07-11 23:13:15 +02:00
hwmon	hwmon: (coretemp) Properly label the sensors	2010-07-09 16:22:51 +02:00
i2c	Merge branch 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging	2010-07-11 13:35:34 -07:00
ide	powerpc/macio: Fix probing of macio devices by using the right of match table	2010-06-02 17:50:38 +10:00
idle	intel_idle: native hardware cpuidle driver for latest Intel processors	2010-05-28 14:26:20 -04:00
ieee1394	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6	2010-05-27 10:22:06 -07:00
ieee802154	…
infiniband	IB/qib: Use request_firmware() to load SD7220 firmware	2010-07-08 13:27:05 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2010-07-22 11:46:15 -07:00
isdn	ISDN: hysdn, fix potential NULL dereference	2010-06-26 22:12:02 -07:00
leds	i2c: Remove all i2c_set_clientdata(client, NULL) in drivers	2010-06-03 11:33:58 +02:00
lguest	…
macintosh	Merge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc	2010-06-03 15:46:37 -07:00
mca	…
md	md/raid5: don't include 'spare' drives when reshaping to fewer devices.	2010-06-24 13:36:04 +10:00
media	V4L/DVB: v4l: mem2mem_testdev: fix g_fmt NULL pointer dereference	2010-07-08 16:50:24 -03:00
memstick	…
message	drivers/message/i2o/i2o_config.c: use memdup_user	2010-05-27 09:12:41 -07:00
mfd	i2c: Remove all i2c_set_clientdata(client, NULL) in drivers	2010-06-03 11:33:58 +02:00
misc	Andres has moved	2010-07-20 16:25:41 -07:00
mmc	ARM: Fix Versatile/Realview/VExpress MMC card detection sense	2010-07-30 23:16:32 +01:00
mtd	Merge git://git.infradead.org/~dwmw2/mtd-2.6.35	2010-06-07 17:10:06 -07:00
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6	2010-07-27 09:21:00 -07:00
nubus	…
of	Merge remote branch 'origin' into secretlab/next-devicetree	2010-05-22 00:36:56 -06:00
oprofile	…
parisc	…
parport	m68k: amiga - Parallel port platform device conversion	2010-05-26 19:51:09 +02:00
pci	PCI: fall back to original BIOS BAR addresses	2010-07-16 11:39:48 -07:00
pcmcia	Merge master.kernel.org:/home/rmk/linux-2.6-arm	2010-07-26 08:20:38 -07:00
platform	intel_scu_ipc: Oops/crash fixes	2010-07-19 13:17:37 -07:00
pnp	…
power	Merge git://git.infradead.org/users/cbou/battery-2.6.35	2010-07-27 09:22:55 -07:00
pps	…
ps3	…
rapidio	rapidio: fix new kernel-doc warnings	2010-05-30 09:02:47 -07:00
regulator	regulator: tps6507x: allow driver to use DEFDCDC{2,3}_HIGH register	2010-07-28 15:09:26 +01:00
rtc	drivers/rtc/rtc-rx8581.c: fix setdatetime	2010-07-27 14:32:06 -07:00
s390	Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6	2010-07-28 20:00:42 -07:00
sbus	drivers/sbus: Remove unnecessary casts of private_data	2010-07-12 21:16:04 -07:00
scsi	[SCSI] ibmvscsi: Fix oops when an interrupt is pending during probe	2010-07-27 11:53:23 -05:00
serial	serial: fix rs485 for atmel_serial on avr32	2010-07-26 11:59:31 -07:00
sfi	SFI: do not return freed pointer	2010-06-01 12:04:35 -04:00
sh	sh: Make intc messages consistent via pr_fmt.	2010-06-02 18:10:00 +09:00
sn	…
spi	powerpc/cpm: Reintroduce global spi_pram struct (fixes build issue)	2010-07-11 11:03:22 -05:00
ssb	ssb: fix NULL ptr deref when pcihost_wrapper is used	2010-05-28 13:57:01 -04:00
staging	Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6	2010-06-30 15:45:59 -07:00
tc	…
telephony	drivers/telephony/ixj.c: use memdup_user	2010-05-27 09:12:42 -07:00
thermal	…
uio	…
usb	Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6	2010-07-26 13:06:39 -07:00
uwb	…
vhost	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6	2010-07-20 16:26:42 -07:00
video	Merge master.kernel.org:/home/rmk/linux-2.6-arm	2010-07-30 19:02:51 -07:00
virtio	virtio: fix oops on OOM	2010-07-26 08:05:31 -07:00
vlynq	…
w1	sysfs: add struct file* to bin_attr callbacks	2010-05-21 09:37:31 -07:00
watchdog	watchdog: at32ap700x_wdt: register misc device last in probe() function	2010-06-17 09:56:57 +00:00
xen	xen: avoid allocation causing potential swap activity on the resume path	2010-06-03 09:34:45 +01:00
zorro	sysfs: add struct file* to bin_attr callbacks	2010-05-21 09:37:31 -07:00
Kconfig	…
Makefile	intel_idle: native hardware cpuidle driver for latest Intel processors	2010-05-28 14:26:20 -04:00