linux_old1/net/ipv6/ila
Tom Herbert 1913540a13 ila: Fix crash caused by rhashtable changes
commit ca26893f05 ("rhashtable: Add rhlist interface")
added a field to rhashtable_iter so that length became 56 bytes
and would exceed the size of args in netlink_callback (which is
48 bytes). The netlink diag dump function already has been
allocating a iter structure and storing the pointed to that
in the args of netlink_callback. ila_xlat also uses
rhahstable_iter but is still putting that directly in
the arg block. Now since rhashtable_iter size is increased
we are overwriting beyond the structure. The next field
happens to be cb_mutex pointer in netlink_sock and hence the crash.

Fix is to alloc the rhashtable_iter and save it as pointer
in arg.

Tested:

  modprobe ila
  ./ip ila add loc 3333:0:0:0 loc_match 2222:0:0:1,
  ./ip ila list  # NO crash now

Signed-off-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-11-02 15:26:02 -04:00
..
Makefile ila: Add generic ILA translation facility 2015-12-15 23:25:20 -05:00
ila.h ila: Perform only one translation in forwarding path 2016-06-08 00:40:34 -07:00
ila_common.c kcm: Use stream parser 2016-08-17 19:36:23 -04:00
ila_lwt.c lwt: Remove unused len field 2016-10-23 17:45:01 -04:00
ila_xlat.c ila: Fix crash caused by rhashtable changes 2016-11-02 15:26:02 -04:00