p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
linux_old1/drivers/input/joystick
History
Dmitry Torokhov c20bc5502d Input: turbografx - fix potential out of bound access 
Patch 17dd3f0f7aa7: "[PATCH] drivers/input/joystick: convert to dynamic
input_dev allocation" from Sep 15, 2005, leads to the following static
checker warning:

        drivers/input/joystick/turbografx.c:235 tgfx_probe()
        error: buffer overflow 'tgfx_buttons' 5 <= 5

drivers/input/joystick/turbografx.c
   195          for (i = 0; i < n_devs; i++) {
   196                  if (n_buttons[i] < 1)
   197                          continue;
   198
   199                  if (n_buttons[i] > 6) {
                            ^^^^^^^^^^^^^^^^
Possibly off by one.  >= 6.

Let's change the upper value to ARRAY_SIZE(tgfx_buttons) to ensure we do
not reach past the end of the array.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
 		2015-08-03 14:11:45 -07:00
..
iforce Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
Kconfig Input: add Austria Microsystem AS5011 joystick driver 2011-01-10 11:01:43 -08:00
Makefile Input: add Austria Microsystem AS5011 joystick driver 2011-01-10 11:01:43 -08:00
a3d.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
adi.c Input: adi - remove an unnecessary check 2015-02-11 23:07:13 -08:00
amijoy.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2012-03-29 23:17:44 -07:00
analog.c Input: joystick - use ktime for measuring timing 2014-09-11 23:41:18 -07:00
as5011.c Input: as5011 - fix error return code in as5011_probe() 2013-08-24 17:44:25 -07:00
cobra.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
db9.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
gamecon.c Update broken web addresses in the kernel. 2010-10-18 11:03:14 +02:00
gf2k.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
grip.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
grip_mp.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
guillemot.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
interact.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
joydump.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
magellan.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
maplecontrol.c Input: joysticks - use dev_get_platdata() 2013-08-12 22:32:30 -07:00
sidewinder.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
spaceball.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
spaceorb.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
stinger.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
tmdc.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
turbografx.c Input: turbografx - fix potential out of bound access 2015-08-03 14:11:45 -07:00
twidjoy.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
walkera0701.c Input: walkera0701 - claim parport when opening the device 2013-01-21 17:32:01 -08:00
warrior.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
xpad.c Input: xpad - re-send LED command on present event 2015-06-22 14:24:58 -07:00
zhenhua.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00