p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
linux_old1/drivers/net/vmxnet3
History
Stanislaw Gruszka 673e63c688 net: fix ethtool->set_flags not intended -EINVAL return value 
After commit d5dbda2380 "ethtool: Add
support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
acceleration via ethtool set_flags, always return -EINVAL from that
function. Fix by returning -EINVAL only if requested features do not
match current settings and can not be changed by driver.

Change any driver that define ethtool->set_flags to use
ethtool_invalid_flags() to avoid similar problems in the future
(also on drivers that do not have the problem).

Tested with modified (to reproduce this bug) myri10ge driver.

Cc: stable@kernel.org # 2.6.37+
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
 		2011-03-27 23:35:24 -07:00
..
Makefile
…
upt1_defs.h vmxnet3: remove set_flag_le{16,64} helpers 2010-10-24 15:52:31 -07:00
vmxnet3_defs.h vmxnet3: remove set_flag_le{16,64} helpers 2010-10-24 15:52:31 -07:00
vmxnet3_drv.c vmxnet3: Dont allocate extra MSI-x vectors 2011-01-15 21:21:14 -08:00
vmxnet3_ethtool.c net: fix ethtool->set_flags not intended -EINVAL return value 2011-03-27 23:35:24 -07:00
vmxnet3_int.h vmxnet3: Dont allocate extra MSI-x vectors 2011-01-15 21:21:14 -08:00