Konstantin Khlebnikov b9ea25152e page_writeback: clean up mess around cancel_dirty_page() ... This patch replaces cancel_dirty_page() with a helper function account_page_cleaned() which only updates counters. It's called from truncate_complete_page() and from try_to_free_buffers() (hack for ext3). Page is locked in both cases, page-lock protects against concurrent dirtiers: see commit 2d6d7f9828 ("mm: protect set_page_dirty() from ongoing truncation"). Delete_from_page_cache() shouldn't be called for dirty pages, they must be handled by caller (either written or truncated). This patch treats final dirty accounting fixup at the end of __delete_from_page_cache() as a debug check and adds WARN_ON_ONCE() around it. If something removes dirty pages without proper handling that might be a bug and unwritten data might be lost. Hugetlbfs has no dirty pages accounting, ClearPageDirty() is enough here. cancel_dirty_page() in nfs_wb_page_cancel() is redundant. This is helper for nfs_invalidate_page() and it's called only in case complete invalidation. The mess was started in v2.6.20 after commits 46d2277c79 ("Clean up and make try_to_free_buffers() not race with dirty pages") and 3e67c0987d ("truncate: clear page dirtiness before running try_to_free_buffers()") first was reverted right in v2.6.20 in commit ecdfc9787f ("Resurrect 'try_to_free_buffers()' VM hackery"), second in v2.6.25 commit a2b345642f ("Fix dirty page accounting leak with ext3 data=journal"). Custom fixes were introduced between these points. NFS in v2.6.23, commit 1b3b4a1a2d ("NFS: Fix a write request leak in nfs_invalidate_page()"). Kludge in __delete_from_page_cache() in v2.6.24, commit 3a6927906f ("Do dirty page accounting when removing a page from the page cache"). Since v2.6.25 all of them are redundant. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Cc: Tejun Heo <tj@kernel.org> Cc: Jan Kara <jack@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2015-04-14 16:49:01 -07:00
..
acpi	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2015-02-19 11:28:36 -08:00
asm-generic	OK, this has the big virtio 1.0 implementation, as specified by OASIS.	2015-02-18 09:24:01 -08:00
clocksource	…
crypto	Merge git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2015-02-14 09:47:01 -08:00
drm	drm/ttm: device address space != CPU address space	2015-03-05 09:04:39 +10:00
dt-bindings	USB patches for 4.1-rc1	2015-04-13 17:07:21 -07:00
keys	…
kvm	KVM/ARM changes for v4.1:	2015-04-07 18:09:20 +02:00
linux	page_writeback: clean up mess around cancel_dirty_page()	2015-04-14 16:49:01 -07:00
math-emu	…
media	[media] media: atmel-isi: increase the burst length to improve the performance	2015-03-02 13:27:11 -03:00
memory	…
misc	…
net	ipv6: protect skb->sk accesses from recursive dereference inside the stack	2015-04-06 16:12:49 -04:00
pcmcia	…
ras	…
rdma	…
rxrpc	…
scsi	libata-eh: Set 'information' field for autosense	2015-03-27 11:59:22 -04:00
soc	pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.	2015-03-03 19:43:59 +01:00
sound	…
target	target: do not reject FUA CDBs when write cache is enabled but emulate_write_cache is 0	2015-03-19 23:26:46 -07:00
trace	Merge branch 'for-4.1' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata	2015-04-13 16:42:16 -07:00
uapi	Staging driver patches for 4.1-rc1	2015-04-13 17:37:33 -07:00
video	OMAPDSS: fix regression with display sysfs files	2015-02-26 10:23:15 +02:00
xen	xen: Remove trailing semicolon from xenbus_register_frontend() definition	2015-03-02 10:38:59 +00:00
Kbuild	…