From 30d5e698b8e0bcfc3e871d1deff4f44b5bd4621c Mon Sep 17 00:00:00 2001 From: Lukas Bulwahn Date: Sat, 28 Jan 2017 10:41:13 +0100 Subject: [PATCH] eigen-stl-containers: depend on libeigen Without the dependency on libeigen, `bitbake eigen-stl-containers` can possibly fail with: ``` | CMake Error at CMakeLists.txt:8 (find_package): | By not providing "FindEigen3.cmake" in CMAKE_MODULE_PATH this project has | asked CMake to find a package configuration file provided by "Eigen3", but | CMake did not find one. | | Could not find a package configuration file provided by "Eigen3" with any | of the following names: | | Eigen3Config.cmake | eigen3-config.cmake | | Add the installation prefix of "Eigen3" to CMAKE_PREFIX_PATH or set | "Eigen3_DIR" to a directory containing one of the above files. If "Eigen3" | provides a separate development package or SDK, be sure it has been | installed. | | | -- Configuring incomplete, errors occurred! ``` The failure only occurs if libeigen has not been installed before eigen-stl-containers is configured. Hence, the regular regression testing with `bitbake core-image-ros-world`, which builds many packages in parallel, did not uncover this because libeigen was usually installed before eigen-stl-containers was configured. However, the issue is clearly reproducible with `bitbake eigen-stl-containers libeigen -c cleanall && bitbake eigen-stl-containers` The missing dependency was probably overlooked in the creation of the eigen-stl-containers recipe, i.e., in commit a255e67c9e5eac62c537ace6d76c885d5b0ae11b. Signed-off-by: Lukas Bulwahn --- recipes-ros/eigen-stl-containers/eigen-stl-containers_0.1.6.bb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/recipes-ros/eigen-stl-containers/eigen-stl-containers_0.1.6.bb b/recipes-ros/eigen-stl-containers/eigen-stl-containers_0.1.6.bb index a388d6a..33e4df1 100644 --- a/recipes-ros/eigen-stl-containers/eigen-stl-containers_0.1.6.bb +++ b/recipes-ros/eigen-stl-containers/eigen-stl-containers_0.1.6.bb @@ -3,6 +3,8 @@ SECTION = "devel" LICENSE = "BSD" LIC_FILES_CHKSUM = "file://package.xml;beginline=9;endline=9;md5=d566ef916e9dedc494f5f793a6690ba5" +DEPENDS = "libeigen" + SRC_URI = "https://github.com/ros/${ROS_SPN}/archive/${PV}.tar.gz;downloadfilename=${ROS_SP}.tar.gz" SRC_URI[md5sum] = "fcc3fdda4010f92aa68f926cd3b8bdd0" SRC_URI[sha256sum] = "24d614921c4ec97f1d5c7905f5e896f1665b2e796c547b4a21504176b4680e47"